Audio: SRC: Add conversions to 11.025 and 22.05 kHz#9945
Merged
lgirdwood merged 4 commits intothesofproject:mainfrom Apr 8, 2025
Merged
Audio: SRC: Add conversions to 11.025 and 22.05 kHz#9945lgirdwood merged 4 commits intothesofproject:mainfrom
lgirdwood merged 4 commits intothesofproject:mainfrom
Conversation
Collaborator
Author
|
Still draft, I'll test locally that new conversions plus existing ones work. |
The added check loads for Octave the signal package. In Matlab it is available if licensed without need for explicitly loading it. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
With these additions the new generated and exported SRC coefficients sets match the existing hand-edited header files for coefficients. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This change adds conversions from 48 and 96 kHz to rates 11.025 and 22.05 kHz. A column for 64 kHz output rate is added for completeness, since it is the only missing standard rate (e.g. for MPEG), but no conversions are activated for it while there is no requirement yet. Some comments are added to script and some formatting is done for readability for supported conversions. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch adds coefficients modifications to support conversion from 48 and 96 kHz to 11.025 and 22.05 kHz. All files were generated with Matlab with run of script sof_src_ipc4_int32.m. The previous set was generated with Matlab, so these were too to minimize the patch since there are differences in the FIR calculation functions in signal processing package. The files with only copyright year changed to this year 2025 but no other changes were left out from patch to keep this small. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
src_add_96k_conversions
branch
from
0901cab to
76b3bee
Compare
abonislawski
approved these changes
Apr 8, 2025
Member
abonislawski
left a comment
abonislawski
left a comment
There was a problem hiding this comment.
@wszypelt can we add new conversion rates to full scope or any other test plan which fully stresses SRC?
| pkg load signal | ||
| end | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
Unnecessary second blank line
|
@singalsu @abonislawski Is the scope we see in the code already final? Mariusz will create new tests, but it will take a while |
lgirdwood
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.