llext: remove unneeded data and functions#9951
Conversation
lyakh
requested review from
a team,
abonislawski,
dbaluta,
fkwasowi,
kv2019i,
lbetlej,
lgirdwood,
mmaka1,
plbossart,
singalsu and
tlissows
as code owners
lyakh
force-pushed
the
adapter
branch
2 times, most recently
from
0f68a8f to
66e5408
Compare
All module adapter drivers interface with the infrastructure using entries similar to DECLARE_MODULE_ADAPTER(src_interface, SRC_UUID, src_tr); SOF_MODULE_INIT(src, sys_comp_module_src_interface_init); which create instances of struct comp_driver and define several functions. They aren't needed when built as a LLEXT module. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
| return 0; | ||
| } | ||
|
|
||
| static int demux_trigger(struct processing_module *mod, int cmd) |
There was a problem hiding this comment.
Should this be a separate commit ?
There was a problem hiding this comment.
@lgirdwood in principle it's all for the same goal - removing unused data and code from modular builds. This hunks don't change any code, they just move it around. Alternatively I could leave those functions where they are and just add #if - #endif to each of them but that would be too ugly. So, if allowed, I'd leave this as is, if however there's a strong desire for splitting this, I can do that too
|
BTW, forgot to mention - the idea was from @softwarecki - thanks! |
|
@wszypelt "Internal Intel CI" failure seems to be unrelated? |
|
CO:
|
|
@lyakh We have noticed a problem with this test on several PRs, we're currently analyzing it, I hope to solve it by the EOD. |
|
@lyakh this breaks a lot of tests on imx8. Looks like for example it breaks IPC3 platforms. |
7 participants
All module adapter drivers interface with the infrastructure using entries similar to
DECLARE_MODULE_ADAPTER(src_interface, SRC_UUID, src_tr); SOF_MODULE_INIT(src, sys_comp_module_src_interface_init);
which create instances of struct comp_driver and define several functions. They aren't needed when built as a LLEXT module.