tools: topology2: cavs-nocodec: Fix PASSTHROUGH configuration for SSPs#9981
Merged
kv2019i merged 1 commit intothesofproject:mainfrom May 5, 2025
Merged
Conversation
The purpose of PASSTHROUGH is to exclude processing modules from paths, but in case of the nocodec topologies the PASSTHROUGH enables formats on the SSP DAI side for which we don't have a blob generated and no hw_config either. We only really support in this mode S32_LE and nothing else, S16_LE and S24_LE formats are invalid. Support only S32_LE on dai side only and do the conversion if needed on the host side so all internal (non-)processing is 32bit. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com> Link: thesofproject#9979
kv2019i
approved these changes
May 2, 2025
lgirdwood
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of PASSTHROUGH is to exclude processing modules from paths, but in case of the nocodec topologies the PASSTHROUGH enables formats on the SSP DAI side for which we don't have a blob generated and no hw_config either.
We only really support in this mode S32_LE and nothing else, S16_LE and S24_LE formats are invalid.
Support only S32_LE on dai side only and do the conversion if needed on the host side so all internal (non-)processing is 32bit.
Link: #9979