chore: Create contract subscription for existing webhook#862
Merged
Conversation
engine-cloud - engine-cloud-devWe're building your pull request over Zeet. We have provided links for Zeet apps linked to this github repo
|
|
We're building your pull request over on Zeet. |
d4mr
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR enhances the
addContractSubscriptionfunctionality by introducing a new optionalwebhookIdparameter, allowing users to either specify an existing webhook or create a new one using awebhookUrl. It improves error handling and ensures proper webhook management.Detailed summary
shortenAddressimport fromthirdweb/utils.webhookIdas an optional parameter in the request body schema.webhookIdorwebhookUrl.createContractSubscriptionto use the determinedwebhookId.