Refactor send-transaction and sign typed data to v5#866
Merged
joaquim-verges merged 1 commit intomainfrom Mar 19, 2025
Merged
Conversation
|
We're building your pull request over on Zeet. |
engine-cloud - engine-cloud-devWe're building your pull request over Zeet. We have provided links for Zeet apps linked to this github repo
|
f56d319 to
9965eb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes
How this PR will be tested
Output
(Example: Screenshot/GIF for UI changes, cURL output for API changes)
PR-Codex overview
This PR focuses on enhancing transaction handling and data signing in the backend, particularly with smart wallets and transaction overrides. It introduces new types, improves error handling, and refines transaction preparation and queuing.
Detailed summary
src/shared/utils/transaction/types.tsto import and define types.src/server/routes/contract/write/write.tsto better handle transaction overrides.src/server/routes/backend-wallet/sign-typed-data.tsto includechainIdandprimaryTypein the request body, improving smart wallet handling.account.signTypedData.src/server/routes/backend-wallet/send-transaction.ts, integrating overrides and simplifying transaction queuing.