-
Notifications
You must be signed in to change notification settings - Fork 637
Add self-managed vault recovery option for lost secret key #8619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add self-managed vault recovery option for lost secret key #8619
Conversation
Introduces an option for users of managed vaults who have lost their secret key to create a new self-managed (ejected) vault. Updates the recovery dialog to allow users to choose between providing their secret key for a managed vault or proceeding with self-management, improving recovery flexibility and user experience.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdds a feature allowing users to choose between managed vaults (using provided secret keys) and self-managed vaults (user controls keys). Introduces Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (9)**/*.{ts,tsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
apps/{dashboard,playground-web}/src/**/*.{ts,tsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
apps/dashboard/src/**/*.{ts,tsx}📄 CodeRabbit inference engine (CLAUDE.md)
Files:
apps/dashboard/**/*.{ts,tsx}📄 CodeRabbit inference engine (.cursor/rules/dashboard.mdc)
Files:
apps/dashboard/**/*.client.tsx📄 CodeRabbit inference engine (.cursor/rules/dashboard.mdc)
Files:
**/*.{js,jsx,ts,tsx,json}📄 CodeRabbit inference engine (AGENTS.md)
Files:
apps/{dashboard,playground}/**/*.{tsx,ts}📄 CodeRabbit inference engine (AGENTS.md)
Files:
apps/{dashboard,playground}/**/*.{ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{ts,tsx,js,jsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
🧬 Code graph analysis (1)apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/wallets/server-wallets/wallets/vault-recovery-card.client.tsx (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (6)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8619 +/- ##
=======================================
Coverage 53.02% 53.02%
=======================================
Files 924 924
Lines 61726 61726
Branches 4035 4035
=======================================
Hits 32730 32730
Misses 28898 28898
Partials 98 98
🚀 New features to boost your workflow:
|
size-limit report 📦
|
Introduces an option for users of managed vaults who have lost their secret key to create a new self-managed (ejected) vault. Updates the recovery dialog to allow users to choose between providing their secret key for a managed vault or proceeding with self-management, improving recovery flexibility and user experience.
PR-Codex overview
This PR introduces a new option for users who have lost their secret key, allowing them to manage vault keys themselves. It modifies the logic around vault creation and user input requirements based on whether the vault is managed or self-managed.
Detailed summary
manageKeysSelfstate for users who lost their secret key.Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.