Upgrade plugins and golang to latest versions#3498
Open
SpangleLabs wants to merge 12 commits intothought-machine:masterfrom
Open
Upgrade plugins and golang to latest versions#3498SpangleLabs wants to merge 12 commits intothought-machine:masterfrom
SpangleLabs wants to merge 12 commits intothought-machine:masterfrom
Conversation
toastwaffle
approved these changes
Mar 18, 2026
SpangleLabs
changed the title
SpangleLabs
added a commit
that referenced
this pull request
Mar 18, 2026
I think this might be required before trying to upgrade the golang version in please repository, (#3498) to enable CircleCI setup to run tests properly Co-authored-by: roselyn <roselyn@thoughtmachine.net>
added 6 commits
March 19, 2026 11:09
…d ignoring errors
Contributor
Author
|
Dang it, I've bisected various changes and the remaining test failure is due to upgrading go-rules from v1.22.0 to v1.23.0, which was a version released by me 1 year ago. I guess we didn't spot this failure back then... Perhaps we should be updating our plugins more frequently |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly, I want the updated version of go-rules, for #3497 , but let's upgrade the others too.
Go rules: v1.21.5 -> v1.29.0
Shell rules: v0.1.1 -> v0.2.1
Python rules: v1.7.4 -> v1.14.0
I held off on upgrading python rules plugin to v2
And the cc-rules plugin is already up to date
And upgrading golang from v1.24.10 to v1.26.1