Fix a few minor issues in Readme#552
Closed
duffuniverse wants to merge 1 commit intothoughtbot:mainfrom
Closed
Conversation
duffuniverse
requested review from
neilvcarvalho and
vburzynski
as code owners
Author
|
Fixed by thoughtbot/factory_bot#1794 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detail
Code ClimatebadgeIt currently doesn't display any useful information.
If you click on the badge, you'll be redirected to the page
https://qlty.sh/login?returnTo=%2Fgh%2Fthoughtbot%2Fprojects%2Ffactory_bot_railsThe guide page
https://github.com/thoughtbot/factory_bot/blob/4-9-0-stable/UPGRADE_FROM_FACTORY_GIRL.mdresponds with404.I'm not sure whether this guide is still relevant.