Skip to content

SCAL-302303: revert unifiedSearchExperienceEnabled to true by default#488

Merged
mouryabalabhadra merged 7 commits intomainfrom
SCAL-302303-1
Mar 31, 2026
Merged

SCAL-302303: revert unifiedSearchExperienceEnabled to true by default#488
mouryabalabhadra merged 7 commits intomainfrom
SCAL-302303-1

Conversation

@mouryabalabhadra
Copy link
Copy Markdown
Collaborator

No description provided.

@mouryabalabhadra mouryabalabhadra requested a review from a team as a code owner March 31, 2026 01:58
utsavkapoor
utsavkapoor previously approved these changes Mar 31, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the isUnifiedSearchExperienceEnabled flag to the AppEmbed configuration, including updates to the AppViewConfig interface, parameter mapping logic, and the Param enum, along with a new unit test. Review feedback identifies several documentation issues in the JSDoc, such as incorrect version mapping and brand naming. Furthermore, it is recommended to optimize the URL size by avoiding default boolean values in destructuring and only appending the parameter to the query string when it is explicitly provided by the caller, adhering to the project's style guidelines.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 31, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@488

commit: a3b5a6d

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
utsavkapoor
utsavkapoor previously approved these changes Mar 31, 2026
@mouryabalabhadra mouryabalabhadra changed the title SCAL-302303: update unifiedSearchExperienceEnabled to false by default SCAL-302303: revert unifiedSearchExperienceEnabled to true by default Mar 31, 2026
@sonar-prod-ts
Copy link
Copy Markdown

sonar-prod-ts bot commented Mar 31, 2026

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mouryabalabhadra mouryabalabhadra merged commit f61aa33 into main Mar 31, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants