SCAL-303837: Add support for enableLiveboardDataCache flag#492
Conversation
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
commit: |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces the enablePbVizDataCaching configuration option to both AppEmbed and LiveboardEmbed, allowing users to enable visualization data caching. The implementation correctly follows the style guide by only adding the parameter to the URL when it is explicitly defined, and corresponding unit tests have been added to verify this behavior. Feedback is provided to remove redundant @type JSDoc tags in src/embed/app.ts and src/embed/liveboard.ts to align with the repository's canonical tag ordering.
|
SonarQube Quality Gate
|
|
LGTM |








LiveboardEmbed
AppEmbed