Skip to content

SCAL-303837: Add support for enableLiveboardDataCache flag#492

Merged
ajeet-lakhani-ts merged 3 commits intomainfrom
SCAL-303837--enablePbVizDataCaching-flag-support
Apr 2, 2026
Merged

SCAL-303837: Add support for enableLiveboardDataCache flag#492
ajeet-lakhani-ts merged 3 commits intomainfrom
SCAL-303837--enablePbVizDataCaching-flag-support

Conversation

@ajeet-lakhani-ts
Copy link
Copy Markdown
Collaborator

@ajeet-lakhani-ts ajeet-lakhani-ts commented Mar 31, 2026

LiveboardEmbed

const tsSearch = new LiveboardEmbed("#tsEmbed", {
  frameParams: {},
  liveboardId: "<id>",
  enableLiveboardDataCache: true/false
});

AppEmbed

const tsSearch = new AppEmbed("#tsEmbed", {
     frameParams: {
     },
     enableLiveboardDataCache: true/false
   });
Embed Type Screenshot
Enabled on LiveboardEmbed
Disabled on LiveboardEmbed
Enabled on Full App Embed Screenshot 2026-04-01 at 12 43 50 PM
Disabled on Full App Embed Screenshot 2026-04-01 at 12 44 13 PM

@ajeet-lakhani-ts ajeet-lakhani-ts requested a review from a team as a code owner March 31, 2026 11:33
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 31, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@492

commit: 0fed91a

@shivam-kumar-ts
Copy link
Copy Markdown
Contributor

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the enablePbVizDataCaching configuration option to both AppEmbed and LiveboardEmbed, allowing users to enable visualization data caching. The implementation correctly follows the style guide by only adding the parameter to the URL when it is explicitly defined, and corresponding unit tests have been added to verify this behavior. Feedback is provided to remove redundant @type JSDoc tags in src/embed/app.ts and src/embed/liveboard.ts to align with the repository's canonical tag ordering.

@ajeet-lakhani-ts ajeet-lakhani-ts changed the title SCAL-303837: Add support for enablePbVizDataCaching flag SCAL-303837: Add support for enableLiveboardDataCache flag Apr 1, 2026
@sonar-prod-ts
Copy link
Copy Markdown

sonar-prod-ts bot commented Apr 1, 2026

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shivam-kumar-ts
Copy link
Copy Markdown
Contributor

LGTM

@ajeet-lakhani-ts ajeet-lakhani-ts merged commit abeb40c into main Apr 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants