fix(ci): run Go tests across all packages#3910
Merged
piotr-roslaniec merged 9 commits intofeature/decouple-firewall-allowlistfrom Mar 27, 2026
Merged
fix(ci): run Go tests across all packages#3910piotr-roslaniec merged 9 commits intofeature/decouple-firewall-allowlistfrom
piotr-roslaniec merged 9 commits intofeature/decouple-firewall-allowlistfrom
Conversation
gotestsum's default `./...` package pattern only applies when no args are passed after `--`. With `-- -timeout 15m`, it forwards args directly to `go test`, which defaults to `.` (root package only). The root package has no test files, so CI has been silently running 0 tests.
piotr-roslaniec
force-pushed
the
fix/ci-gotestsum-missing-packages
branch
from
16fafed to
3830ab7
Compare
Replace placeholder hostnames with actual values from config/_peers/testnet.
Remove TestConnectedWellknownPeersCountMetricName and TestMetricConstants which only assert that string constants equal themselves. The compiler already ensures rename safety. Keep the callable integration test which validates the function exists and executes without panicking.
…d var Change EmptyAllowList from an exported mutable package-level var to an exported function returning the package-level singleton. This prevents external code from accidentally mutating the shared empty allowlist.
Add a note that connected_wellknown_peers_count was previously named connected_bootstrap_count, so operators can update Prometheus queries and Grafana dashboards accordingly.
Specify concrete removal version so the deprecated flag does not linger indefinitely.
Add a TODO comment noting that at least one additional mainnet peer across a different operator/ASN should be added before production rollout to avoid a single point of failure for initial peer discovery.
piotr-roslaniec
force-pushed
the
fix/ci-gotestsum-missing-packages
branch
from
0eacdc5 to
834b63a
Compare
Go 1.24 vet rejects non-constant format strings in fmt.Errorf. This pre-existing issue was hidden because CI was not running tests.
piotr-roslaniec
merged commit 16ace1b
into
feature/decouple-firewall-allowlist
15 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gotestsum -- -timeout 15m(without./...) only tests the root package, which has no test files./...so all subpackages are testedpeers_test.goplaceholder hostnames to match actualconfig/_peers/testnetvalues — this test failure was hidden by the above bugRoot cause
gotestsum's default./...package pattern only applies when no args are passed after--. With-- -timeout 15m, gotestsum forwards args directly togo test, which defaults to.(current directory only). CI log confirms:DONE 0 tests in 8.107s.Test plan
TestResolvePeers/sepolia_networkshould pass with corrected hostnames🤖 Generated with Claude Code