Skip to content

fix(ci): allow ECR publish on workflow_dispatch and relax OIDC trust policy#369

Merged
Sancus merged 1 commit intostagefrom
fix/ci-oidc-and-publish
Mar 19, 2026
Merged

fix(ci): allow ECR publish on workflow_dispatch and relax OIDC trust policy#369
Sancus merged 1 commit intostagefrom
fix/ci-oidc-and-publish

Conversation

@e9e4e5f0faef
Copy link
Copy Markdown
Collaborator

Summary

  • Allow the ECR publish job to run on workflow_dispatch events (previously only push)
  • Remove job_workflow_ref from IAM OIDC trust policy (not supported by aws-actions/configure-aws-credentials)

Changes

File Change
.github/workflows/build-and-push.yml Add workflow_dispatch to publish and publish-disabled job conditions
infra/pulumi/__main__.py Remove job_workflow_ref and redundant iss from OIDC trust policy

Why

Two CI issues discovered during stage deployment validation:

  1. Publish never ran on manual dispatch: the publish job condition required github.event_name == 'push', so workflow_dispatch builds succeeded but never pushed to ECR. stage-latest was stale since Feb 27.

  2. Push-triggered builds failed OIDC auth: the job_workflow_ref claim is present in GitHub OIDC tokens but aws-actions/configure-aws-credentials does not pass it to sts:AssumeRoleWithWebIdentity. Including it as an IAM trust policy condition caused all push events to fail.

Validation

  • OIDC trust policy fix already applied to AWS via pulumi up (IAM role updated immediately)
  • Manual dispatch confirmed working after the trust policy fix
  • All three ECS services (web, worker, versioncheck) running healthy on stage using the corrected stage-latest image

Safety

No impact on running services. The trust policy change is already live in AWS; this PR syncs the code to match.

@e9e4e5f0faef e9e4e5f0faef force-pushed the fix/ci-oidc-and-publish branch from de83d0a to f313b2c Compare March 18, 2026 17:04
@e9e4e5f0faef e9e4e5f0faef requested review from Sancus March 18, 2026 17:16
@Sancus Sancus merged commit 01363c0 into stage Mar 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants