Skip to content

ChangeLog Navigation Via DeepLink#10987

Open
shamim-emon wants to merge 13 commits into
thunderbird:mainfrom
shamim-emon:fix-issue-10897
Open

ChangeLog Navigation Via DeepLink#10987
shamim-emon wants to merge 13 commits into
thunderbird:mainfrom
shamim-emon:fix-issue-10897

Conversation

@shamim-emon
Copy link
Copy Markdown
Collaborator

@shamim-emon shamim-emon commented May 6, 2026 •
edited
Loading

What this PR does

  • It adds deep-link navigation support for the changelog feature. You can now programmatically open either the full changelog or the “recent changes” screen from anywhere in the app (or even from external intents) using the existing FeatureLauncherTarget system.This brings the changelog in line with the newer navigation architecture while still supporting the legacy UI code.
  • This change also converts the Changelog/Recent Changes screen to a fully Compose-based implementation.

Key changes

New module

  • feature/navigation/changelog/api – a clean Kotlin Multiplatform navigation API.
    • ChangelogRoute (serializable, base path app://changelog/{mode}).
    • ChangelogNavigation interface.
    • ChangeLogMode enum (CHANGE_LOG / RECENT_CHANGES) (Pre-existing but now moved into this module).

Launcher updates

  • FeatureLauncherTarget.Changelog data class that builds the proper deep-link URI.
  • FeatureLauncherNavHost now registers the changelog routes.

Clean-up

  • Removed RecentChangeActivity & ChangelogFragment.

@shamim-emon shamim-emon requested a review from a team as a code owner May 6, 2026 16:05
@shamim-emon shamim-emon requested a review from wmontwe May 6, 2026 16:05
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026 •
edited
Loading

✅ Validation Passed: All report and feature-flag labels are correctly set.

@shamim-emon shamim-emon added the report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users). label May 6, 2026
@shamim-emon shamim-emon force-pushed the fix-issue-10897 branch 3 times, most recently from ebfeb7e to f576d0c Compare May 13, 2026 14:21
shamim-emon added 12 commits May 23, 2026 21:48
@shamim-emon
feat: add new module :changelog:api
a9e9b09
@shamim-emon
feat: add changelog:api dependency in :feature:launch and :legacy:ui:…
3cfa070 
…legacy module
@shamim-emon
feat: add ChangelogNavigation implementation
272ec0a
@shamim-emon
feat: register ChangelogNavigation in FeatureLauncherNavHost
6bc57f4
@shamim-emon
feat: add Changelog target to FeatureLauncher
1f5c26b
@shamim-emon
refactor(AboutFragment): migrate Changelog navigation from XML to Fea…
5746b8f 
…tureLauncherActivity using FeatureLauncherTarget
@shamim-emon
refactor(ChangelogScreen): add Scaffold and TopAppBar
85515db
@shamim-emon
refactor(ChangelogScreenPreview): update ChangelogScreenPreview to ma…
8614362 
…tch ChangelogScreen changes
@shamim-emon
refactor(LegacyMessageListFragment): launch RecentChange Screen via d…
3cce085 
…eeplink
@shamim-emon
refactor(MessageListFragment): launch RecentChange Screen via deeplink
260d41f
@shamim-emon
refactor:remove ChangelogFragment as it's no longer in use
c18089a
@shamim-emon
refactor:remove RecentChangeActivity as it's no longer in use
daa5239
wmontwe
wmontwe reviewed May 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@wmontwe wmontwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Just some small findings and I think the namespace should be feature:changelog instead of feature:navigation:changelog.

Optional tasks:

  • The library used for the changelog handling is deprecated and needs to be replaced. Maybe something for you?
  • The UI could be moved to feature:changelog:internal

Comment thread settings.gradle.kts
https://developer.android.com/build/jdks#jdk-config-in-studio
""".trimIndent()
}
include(":feature:navigation:changelog:api")
Copy link
Copy Markdown
Member

@wmontwe wmontwe May 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already added above

Comment thread legacy/ui/legacy/src/main/java/com/fsck/k9/ui/changelog/ChangelogViewModel.kt
}
}
private suspend fun loadState() {
Log.i("EMON1234 MODE:${mode.name}")
Copy link
Copy Markdown
Member

@wmontwe wmontwe May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be removed

Comment thread legacy/ui/legacy/src/main/java/com/fsck/k9/ui/changelog/ChangelogScreen.kt
modifier: Modifier = Modifier,
onShowRecentChangesCheck: (Boolean) -> Unit,
modifier: Modifier = Modifier,
onBack: () -> Unit,
Copy link
Copy Markdown
Member

@wmontwe wmontwe May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onBack should be placed before modifier

Comment thread legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/AboutFragment.kt
.navigate(R.id.action_aboutScreen_to_changelogScreen)
is Effect.OpenChangeLog -> {
FeatureLauncherActivity.launch(
context = context,
Copy link
Copy Markdown
Member

@wmontwe wmontwe May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use requireContext() here.

Comment thread legacy/ui/legacy/src/main/java/com/fsck/k9/ui/settings/AboutFragment.kt
FeatureLauncherActivity.launch(
context = context,
target = FeatureLauncherTarget.Changelog(changeLogMode = ChangeLogMode.CHANGE_LOG),

Copy link
Copy Markdown
Member

@wmontwe wmontwe May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline could be removed

Comment thread feature/navigation/changelog/api/build.gradle.kts
Copy link
Copy Markdown
Member

@wmontwe wmontwe May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is indeed about navigation, the changelog library is deprecated and we need to replace it by our own implementation. With the already migrated UI, it make sense to move this to feature:changelog.

Comment thread feature/navigation/changelog/api/build.gradle.kts
}
sourceSets {
commonMain.dependencies {
implementation(libs.kotlinx.serialization.json)
Copy link
Copy Markdown
Member

@wmontwe wmontwe May 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kotlinx-serialization-json is not needed as it's part of our kmp library already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmontwe wmontwe wmontwe left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@wmontwe wmontwe

Labels

report: exclude Exclude changes from user-facing reports (internal, minor, or not relevant to users).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Changelog Via Feature Launcher

2 participants

@shamim-emon @wmontwe