fix(ui): add spacing between items on the headers screen#11003
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
Insert a blank line between each header entry on the "Show headers" screen so the per-header boundary is visually obvious. The previous single-newline separator made consecutive name/value pairs run together, particularly with long values such as X-Spam-Report. Closes thunderbird#9452
Contributor
|
✅ Validation Passed: All report and feature-flag labels are correctly set. |
Contributor
Author
|
@rafaeltonholo gentle nudge -- this PR is blocked on the require-report-label check (no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Show headers" screen previously placed each
name: valuepair on consecutive lines separated by a single newline, which made it hard to tell where one header ended and the next began, particularly with long values such asX-Spam-Report. This change inserts a blank line between header entries so each item is visually distinct.This matches the scope @rafaeltonholo proposed in #9452 as a good-first-issue workaround for the larger "Show headers" rework that is not on the current roadmap. It does not change how individual values are folded/decoded.
Before / after
The change in
MessageHeadersFragment#populateHeadersListis the separator between entries: a single\nbecomes a double\n. Visually the headers screen now reads:instead of
Prior to submitting a pull request, please familiarize yourself with...
Reviewed the Architecture docs and ADR index, Mozilla's Community Participation Guidelines, and the contribution code quality guides (including the git commit guide for the commit title format used here).
Please ensure that your pull request meets the following requirements - thanks!
main.Closes #9452below.Closes #9452