Skip to content

fix(ui): add spacing between items on the headers screen#11003

Open
mvanhorn wants to merge 1 commit into
thunderbird:mainfrom
mvanhorn:osc/9452-show-headers-padding
Open

fix(ui): add spacing between items on the headers screen#11003
mvanhorn wants to merge 1 commit into
thunderbird:mainfrom
mvanhorn:osc/9452-show-headers-padding

Conversation

@mvanhorn
Copy link
Copy Markdown
Contributor

Summary

The "Show headers" screen previously placed each name: value pair on consecutive lines separated by a single newline, which made it hard to tell where one header ended and the next began, particularly with long values such as X-Spam-Report. This change inserts a blank line between header entries so each item is visually distinct.

This matches the scope @rafaeltonholo proposed in #9452 as a good-first-issue workaround for the larger "Show headers" rework that is not on the current roadmap. It does not change how individual values are folded/decoded.

Before / after

The change in MessageHeadersFragment#populateHeadersList is the separator between entries: a single \n becomes a double \n. Visually the headers screen now reads:

From: alice@domain.example

To: bob@domain.example

Subject: Hi Bob

instead of

From: alice@domain.example
To: bob@domain.example
Subject: Hi Bob

Prior to submitting a pull request, please familiarize yourself with...

Reviewed the Architecture docs and ADR index, Mozilla's Community Participation Guidelines, and the contribution code quality guides (including the git commit guide for the commit title format used here).

Please ensure that your pull request meets the following requirements - thanks!

  • No merge commits; branch is rebased on main.
  • Single commit with a descriptive Conventional Commits title.
  • New code is Kotlin and matches the existing style of the surrounding file.
  • Title is descriptive and contains no issue number.
  • Body references the issue with Closes #9452 below.
  • Cosmetic change; the before/after text rendering above stands in for screenshots.
  • AI disclosure: authored with Claude as a coding assistant; I reviewed the change before pushing.

Closes #9452

Insert a blank line between each header entry on the "Show headers"
screen so the per-header boundary is visually obvious. The previous
single-newline separator made consecutive name/value pairs run together,
particularly with long values such as X-Spam-Report.

Closes thunderbird#9452
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

Validation Passed: All report and feature-flag labels are correctly set.

@mvanhorn
Copy link
Copy Markdown
Contributor Author

@rafaeltonholo gentle nudge -- this PR is blocked on the require-report-label check (no report: label set). Could you add report: include when you get a chance? The change is a small UI spacing fix that's visible to users, so it seems worth a release-note line, but I'm fine with report: exclude if you'd rather keep release notes terse.

@wmontwe wmontwe added the report: include Include changes in user-facing reports. label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

report: include Include changes in user-facing reports.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Show headers" collapses multi-line headers onto one line, making them not authentic and often unreadable

3 participants