Modernize FetchingMailSettings#11044
Open
shamim-emon wants to merge 24 commits into
Open
Conversation
…etchingMailSettings
…ccountAdvancedFetchingMailSettings
…nds under AccountSettingsDomainContract
…eFetchingMailSettings
…Settings and AccountSettingsRoute.AdvancedFetchingMailSettings
…Contract.SettingsBuilder and FetchingMailSettingsViewModel in AccountSettingsModule
Contributor
|
✅ Validation Passed: All report and feature-flag labels are correctly set. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the Fetching Mail Settings screen (including the Advanced version) from the old XML to Jetpack Compose. It is part of the ongoing Thunderbird for Android UI modernization effort and fully replaces the legacy UI while preserving all existing functionality.
What changed
Added a new reusable Compose component
ActionText(with preview) and integrated it intoSettingItemAdded necessary string resources and
FetchingMailSettingsIdUpdated Gradle dependencies, navigation (
AccountSettingsRoute,FeatureLauncherTarget), and legacyAccountSettingsFragmentIntroduced the full Compose architecture:
FetchingMailSettingsContractFetchingMailSettingsBuilderUpdateFetchingMailSettingsUseCase + implementationFetchingMailSettingsViewModelFetchingMailSettingsContent/FetchingMailSettingsScreenAdvancedFetchingMailSettingsContent/AdvancedFetchingMailSettingsScreenFollows the established MVI (Model-View-Intent) architecture with Unidirectional Data Flow (UDF) using the Contract pattern already adopted across the app
Added unit tests for the builder, ViewModel, and UseCase