Skip to content

Conversation

@Oksamies
Copy link
Contributor

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Dec 23, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 12-23-refactor_streamline_beta_switch_initialization_and_add_tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor Author

Oksamies commented Dec 23, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.


const w: TestWindow = {
location: {
hostname: "thunderstore.temp",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test uses outdated hostname. The implementation changed from thunderstore.temp to thunderstore.localhost (beta-switch.js line 130, index.ts line 185), but the test still uses the old value. While the test may still pass due to fallback logic, it's not properly testing the dev environment detection.

hostname: "thunderstore.localhost",
Suggested change
hostname: "thunderstore.temp",
hostname: "thunderstore.localhost",

Spotted by Graphite Agent

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@Oksamies Oksamies merged commit f60bdf3 into xmas-features Dec 23, 2025
19 of 24 checks passed
@Oksamies Oksamies deleted the 12-23-refactor_streamline_beta_switch_initialization_and_add_tests branch December 23, 2025 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants