fix(web): show actual selected model for sessions#269
Draft
webwww123 wants to merge 1 commit intotiann:mainfrom
Draft
fix(web): show actual selected model for sessions#269webwww123 wants to merge 1 commit intotiann:mainfrom
webwww123 wants to merge 1 commit intotiann:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaultmodelModefor sessions that do not store a concrete modelWhy
Issue #267 reports that creating a Codex session with
gpt-5.4still showsmodel: defaultin the web UI. This PR addresses the confusing display part.I intentionally did not bundle Codex effort controls into this PR, because that requires additional hub / session-config plumbing and is better handled separately.
Validation
docker run --rm -v /root/sandbox/hapi-pr:/workspace -w /workspace oven/bun:1 sh -lc "bun install && cd cli && bun run typecheck && cd /workspace/web && bunx vitest run src/lib/sessionModelLabel.test.ts && bun run typecheck"