Merged
Conversation
- TiDB sink: 29 tests for infer_mysql_type, escape_ident, convert_bool_string_for_tinyint, extract_max_length, sanitize_numeric_value, is_numeric_column, is_table_not_found_error - S3 content partitioned sink: 12 tests for object_key, key_from_event, message_bytes, PartitionKey - file_list checkpoint: 8 tests for save/load, completed tracking, path sanitization, error handling Made-with: Cursor
|
|
chenjiandongx
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces several new Vector extension components, enhances existing ones, and adds comprehensive unit test coverage:
New Sinks
src/sinks/tidb/): Write log events to MySQL/TiDB databases with auto-create table, batch inserts, schema-aware type mapping, boolean/numeric value sanitization, and string truncationsrc/sinks/s3_content_partitioned/): Upload log content to S3 partitioned bycomponentandhour_partitionfields, with optional gzip compression and configurable part sizeNew Sources
src/sources/delta_lake_watermark/): Read Delta Lake tables via DuckDB with watermark-based incremental sync, checkpoint persistence, and configurable query patternssrc/sources/file_list/): List and stream files from S3/object stores with built-in log line parsing (Python logging, HTTP access log), path resolution for known o11y data types (raw_logs, slowlog, sql_statement, top_sql, conprof), and checkpoint-based resumeEnhancements
CI & Infrastructure
.github/workflows/test_coverage.yml)Unit Tests (49 new tests)
infer_mysql_type,escape_ident,convert_bool_string_for_tinyint,extract_max_length,sanitize_numeric_value,is_numeric_column,is_table_not_found_errorobject_keygeneration,key_from_eventextraction,message_byteshandling,PartitionKeyequalityAll 448 tests pass (including the 49 new ones).
Test Plan
cargo test --lib→ 448 passed, 0 failed)