This repository was archived by the owner on Apr 4, 2019. It is now read-only.
[BUGFIX] Cleanup morph of each else section #442
Open
Saranya-Raaj wants to merge 1 commit intotildeio:masterfrom
Open
[BUGFIX] Cleanup morph of each else section #442Saranya-Raaj wants to merge 1 commit intotildeio:masterfrom
Saranya-Raaj wants to merge 1 commit intotildeio:masterfrom
Conversation
Contributor
|
this needs tests |
Contributor
Author
|
I am facing issues in running test cases. I'll commit once i am able to run. |
Contributor
Author
|
@stefanpenner I have added a test case. |
Contributor
|
Can you squash? |
Saranya-Raaj
force-pushed
the
eachhelper-destroyelement
branch
from
17893f1 to
3ea0c7d
Compare
Contributor
Author
|
@rwjblue done |
| visitChildren(morph.childNodes, function (node) { | ||
| clearMorph(node, env, true); | ||
| }); | ||
| } |
Collaborator
There was a problem hiding this comment.
Can someone explain the logic of this change? I don't see how clearing all the morphs when adding a new item is the right thing to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes emberjs/ember.js#12716