fix(composio): update GitHub action slugs to current values#2835
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughTest references to GitHub Composio action slugs were updated to current v3 names and a slug-regression test suite was added to validate curated slug constants and lists. ChangesGitHub Composio Action Slug Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
staimoorulhassan
left a comment
There was a problem hiding this comment.
all good here.
Fixes tinyhumansai#2768. Three outdated Composio v1/v2 GitHub action slugs were still referenced in tests: - GITHUB_USERS_GET_AUTHENTICATED → GITHUB_GET_THE_AUTHENTICATED_USER (auth_retry_tests.rs) - GITHUB_LIST_REPOS → GITHUB_LIST_REPOSITORIES_FOR_THE_AUTHENTICATED_USER (composio_tests.rs, two occurrences) - GITHUB_LIST_ISSUES → GITHUB_LIST_REPOSITORY_ISSUES (payload_summarizer.rs) Also adds slug-regression tests to memory_sync/composio/providers/github/tests.rs that pin the correct v3 slug names and assert that every known retired slug is absent from the GITHUB_CURATED whitelist, preventing silent regressions in future.
48500bf to
3ff0f6f
Compare
graycyrus
left a comment
There was a problem hiding this comment.
@staimoorulhassan hey! the code looks good to me — clean fix, well-structured regression tests, and I like that the curated list assertions cover both the retired slugs and the required current ones in a single pass. CI is still pending across most of the matrix though, so I'll hold off on approving until those are green. once they pass, I'll come back and approve this. let me know if anything's blocking you.
graycyrus
left a comment
There was a problem hiding this comment.
Test-only PR fixing four outdated Composio GitHub action slug strings (v1/v2 → v3) across auth_retry_tests.rs, composio_tests.rs, and payload_summarizer.rs. Also adds a new regression test suite in memory_sync/composio/providers/github/tests.rs that pins the correct slug values and asserts retired slugs are absent from GITHUB_CURATED.
Summary:
- Breaking risk: Zero — all changes are confined to test files; no production code paths are touched.
- Security risk: Zero — no auth, secrets, serialization, or network-facing code changed.
Code quality:
Code is solid — the retired-slug blocklist and required-slug assertions are a good long-term guard against re-introducing Composio v3 catalog changes that break the provider.
Status: Waiting on CI green before approving. Current status: 13 passed, 11 pending.
Fixes #2768.
Summary
Three outdated Composio v1/v2 GitHub action slugs were still referenced in tests, causing sync failures when the backend rejected the obsolete names at runtime:
GITHUB_USERS_GET_AUTHENTICATED→GITHUB_GET_THE_AUTHENTICATED_USER(auth_retry_tests.rs)GITHUB_LIST_REPOS→GITHUB_LIST_REPOSITORIES_FOR_THE_AUTHENTICATED_USER(composio_tests.rs, two occurrences)GITHUB_LIST_ISSUES→GITHUB_LIST_REPOSITORY_ISSUES(payload_summarizer.rs)Additionally adds slug-regression tests in
memory_sync/composio/providers/github/tests.rsthat:ACTION_GET_AUTHENTICATED_USERandACTION_SEARCH_ISSUESconstants to their correct v3 valuesGITHUB_USERS_GET_AUTHENTICATED,GITHUB_LIST_REPOS,GITHUB_LIST_ISSUES,GITHUB_COMMIT_MULTIPLE_FILES,GITHUB_CLOSE_AN_ISSUE,GITHUB_DELETE_A_BRANCH) are absent fromGITHUB_CURATEDTest plan
pnpm debug rustpasses — existing + new tests all greenpnpm debug rust githubruns the new slug regression tests specificallyGITHUB_USERS_GET_AUTHENTICATED,GITHUB_LIST_REPOS, orGITHUB_LIST_ISSUESremain in the source treeSummary by CodeRabbit