fix(intelligence): Graph Cohesion — FP rounding, findBrokers cap, i18n flat (follow-up to #2978)

[staimoorulhassan]

Summary

Follow-up fixes on top of PR #2978 (feat(intelligence): add Graph Cohesion), addressing the major review finding and the cross-cutting i18n blocker:

Fixes applied

1. Cross-platform FP stability (graphCohesion.ts)
averageClustering and transitivity are now rounded to 6 decimal places before being returned. The original summing-in-sorted-order approach prevents input-permutation variance but not cross-architecture variance (x86-64 vs ARM differ at the ULP level). 6 d.p. is well within display precision and eliminates visible jitter when syncing across devices.

2. findBrokers default cap
Default limit bumped from 25 → 100. Prevents the caller from accidentally materializing the full ranked list for large graphs when they forget to pass a limit.

3. Monotonic token — already correct (GraphCohesionTab.tsx)
Verified the token comparison uses requestId !== latestRequestId.current (strict !==, not >=). No change needed.

4. i18n — flat locale files (all 13 non-English locales)
The original PR added graphCohesion.* keys to the retired chunks/ directory. Upstream main has no chunks/ directory. This PR writes the same keys directly into ar.ts, bn.ts, … zh-CN.ts with real translations in each language.

Test plan

• pnpm typecheck — clean (no type changes to non-test code)
• pnpm i18n:check — parity clean (same key set across all 14 locale files)
• pnpm i18n:english:check — should pass (real translations, no English placeholders)
• Existing 33 graphCohesion.test.ts tests unchanged — pure engine, no rounding change to integer-valued fields

Summary by CodeRabbit

• Improvements

  • Graph cohesion metrics now return values rounded to 6 decimal places for consistent, reliable network measurements.
  • Increased the default maximum number of broker nodes returned from 25 to 100 to surface more connectivity points.
  • Cohesion view now loads namespace options more robustly and non-blockingly, falling back to an empty list on load errors.

• Tests

  • Added comprehensive tests covering edge cases, determinism, order-independence, and exact clustering/transitivity expectations.
  • UI test updated to assert the rendered brokers/relations table instead of locale-specific heading text.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Rounds averageClustering and transitivity to 6 decimals, raises findBrokers' default limit to 100, refactors namespace loading in the GraphCohesionTab, and adds Vitest coverage for metrics, normalization, determinism, sorting, and broker selection.

Changes

Graph Cohesion Metrics and Broker Parameters

Layer / File(s)	Summary
Rounding precision for cohesion metrics app/src/lib/memory/graphCohesion.ts	computeGraphCohesion now rounds averageClustering and transitivity to 6 decimal places via an internal round6 helper.
Broker discovery default limit update app/src/lib/memory/graphCohesion.ts	findBrokers default limit parameter increased from 25 to 100.
Cohesion tab namespace loading & mount test app/src/components/intelligence/GraphCohesionTab.tsx, app/src/components/intelligence/GraphCohesionTab.test.tsx	Refactors namespace loading in useEffect to an async loadNamespaceOptions with error fallback and updates the mount test to assert the broker/relations table (role="table").
Test suite for cohesion computation and broker selection app/src/lib/memory/graphCohesion.test.ts	Adds Vitest helpers and tests for baseline clustering/triangle counts, diamond-graph metrics (exact rounded averageClustering), normalization (self-loops, undirected parallel-edge collapsing, malformed relation dropping, case sensitivity), determinism/order-independence (including byte-identical averageClustering across permutations), node sort order (clustering DESC, degree DESC, id ASC), and broker filtering/limit behavior.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• tinyhumansai/openhuman#2978: Changes to Graph Cohesion implementation and tests that touch the same metrics rounding, broker limit, and cohesion tab behavior.

Suggested reviewers

• graycyrus

Poem

I am a rabbit, quick and spry,
I round the numbers, watch them fly,
Six decimals tidy up the score,
Brokers stretch their limits evermore. 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 40.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely summarizes the three main changes: FP rounding for numerical stability, increased findBrokers default cap, and i18n improvements—directly matching the changeset's core fixes.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 3

🧹 Nitpick comments (2)

app/src/components/intelligence/GraphCohesionTab.tsx (1)

40-46: ⚡ Quick win

Use async/await consistently in the mount effect.

The loadNamespaces() chain is the one remaining promise chain in this component. Converting it to async/await keeps the effect consistent with the rest of the file and aligns with the repo rule.

♻️ Suggested refactor

   useEffect(() => {
     // Namespaces are optional UI sugar; a failure to list them must not block
     // the cohesion view, so swallow that error specifically.
-    loadNamespaces()
-      .then(setNamespaces)
-      .catch(() => setNamespaces([]));
+    const loadNamespaceOptions = async (): Promise<void> => {
+      try {
+        setNamespaces(await loadNamespaces());
+      } catch {
+        setNamespaces([]);
+      }
+    };
+
+    void loadNamespaceOptions();
     void load('');
   }, [load]);

As per coding guidelines, "Always use async/await for promises in TypeScript".

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/components/intelligence/GraphCohesionTab.tsx` around lines 40 - 46,
The mount effect currently mixes promise chains for loadNamespaces() with
.then/.catch; refactor useEffect to an async inner function that awaits
loadNamespaces(), calls setNamespaces(result) on success, and uses a try/catch
to swallow errors and call setNamespaces([]) on failure; also await (or
explicitly call) load('') from the same async function (or keep the existing
void load('') call) so the effect consistently uses async/await; target the
useEffect that references loadNamespaces, setNamespaces, and load to make the
change and remove the .then/.catch chain.

app/src/components/intelligence/GraphCohesionTab.test.tsx (1)

41-46: ⚡ Quick win

Avoid pinning the happy-path test to a specific translation string.

This will fail on copy-only or locale changes even if the results UI still renders correctly. Prefer asserting on a stable behavior signal from the loaded result instead of the current English heading.

As per coding guidelines, "Prefer behavior over implementation details in unit tests".

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/components/intelligence/GraphCohesionTab.test.tsx` around lines 41 -
46, The test for GraphCohesionTab is brittle because it asserts a specific
English heading; update the assertion to check a stable behavior signal produced
after mockLoadCohesion resolves (e.g., presence of a DOM element or test-id
rendered by GraphCohesionTab such as a graph container, summary element, or list
of results) instead of the exact text "Brokers — loosest neighbourhoods"; keep
the existing render(<GraphCohesionTab />) and the mockLoadCohesion call
assertion, then replace the screen.getByText(...) expectation with an assertion
that a stable element (for example getByTestId('cohesion-graph') or
getByRole('figure') or an item from the loaded result) is in the document so the
test validates behavior not a locale-specific string.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/src/lib/i18n/it.ts`:
- Around line 325-337: The labels 'graphCohesion.namespaceLabel' and
'graphCohesion.colLinks' are still anglicized; update their Italian translations
to match the rest of the locale (use a proper Italian term for namespace and for
links), e.g. replace the value for graphCohesion.namespaceLabel with "Spazio dei
nomi" (or the project's chosen Italian phrase for namespace) and replace
graphCohesion.colLinks with "Collegamenti" so they are consistent with
graphCohesion.metricConnections ("Connessioni") and the rest of the it.ts
translations.

In `@app/src/lib/i18n/ru.ts`:
- Around line 324-325: The i18n value for key 'graphCohesion.summaryCaption'
contains incorrect Russian grammar ("Среднее кластеризация"); update the
translation for 'graphCohesion.summaryCaption' so the metric label is
grammatical (for example, "Средняя кластеризация {avg} · транзитивность
{transitivity}" or "Средний коэффициент кластеризации {avg} · транзитивность
{transitivity}"), replacing the current string in the ru.ts locale to match the
en.ts key.

In `@app/src/lib/memory/graphCohesion.test.ts`:
- Around line 114-117: The test asserts r.averageClustering to 12 decimal places
but the implementation rounds averageClustering to 6 decimals; update the
assertion in graphCohesion.test (the it block checking average clustering using
r.averageClustering) to use 6-digit precision (toBeCloseTo(..., 6)) so the
expected precision matches the rounded engine output.

---

Nitpick comments:
In `@app/src/components/intelligence/GraphCohesionTab.test.tsx`:
- Around line 41-46: The test for GraphCohesionTab is brittle because it asserts
a specific English heading; update the assertion to check a stable behavior
signal produced after mockLoadCohesion resolves (e.g., presence of a DOM element
or test-id rendered by GraphCohesionTab such as a graph container, summary
element, or list of results) instead of the exact text "Brokers — loosest
neighbourhoods"; keep the existing render(<GraphCohesionTab />) and the
mockLoadCohesion call assertion, then replace the screen.getByText(...)
expectation with an assertion that a stable element (for example
getByTestId('cohesion-graph') or getByRole('figure') or an item from the loaded
result) is in the document so the test validates behavior not a locale-specific
string.

In `@app/src/components/intelligence/GraphCohesionTab.tsx`:
- Around line 40-46: The mount effect currently mixes promise chains for
loadNamespaces() with .then/.catch; refactor useEffect to an async inner
function that awaits loadNamespaces(), calls setNamespaces(result) on success,
and uses a try/catch to swallow errors and call setNamespaces([]) on failure;
also await (or explicitly call) load('') from the same async function (or keep
the existing void load('') call) so the effect consistently uses async/await;
target the useEffect that references loadNamespaces, setNamespaces, and load to
make the change and remove the .then/.catch chain.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0290d2fb-9bd3-42ca-969c-0c670622edfa

📥 Commits

Reviewing files that changed from the base of the PR and between 3556842 and f9175e0.

📒 Files selected for processing (23)

• app/src/components/intelligence/GraphCohesionPanel.test.tsx
• app/src/components/intelligence/GraphCohesionPanel.tsx
• app/src/components/intelligence/GraphCohesionTab.test.tsx
• app/src/components/intelligence/GraphCohesionTab.tsx
• app/src/lib/i18n/ar.ts
• app/src/lib/i18n/bn.ts
• app/src/lib/i18n/de.ts
• app/src/lib/i18n/en.ts
• app/src/lib/i18n/es.ts
• app/src/lib/i18n/fr.ts
• app/src/lib/i18n/hi.ts
• app/src/lib/i18n/id.ts
• app/src/lib/i18n/it.ts
• app/src/lib/i18n/ko.ts
• app/src/lib/i18n/pl.ts
• app/src/lib/i18n/pt.ts
• app/src/lib/i18n/ru.ts
• app/src/lib/i18n/zh-CN.ts
• app/src/lib/memory/graphCohesion.test.ts
• app/src/lib/memory/graphCohesion.ts
• app/src/pages/Intelligence.tsx
• app/src/services/api/graphCohesionApi.test.ts
• app/src/services/api/graphCohesionApi.ts

[staimoorulhassan]

All three actionable CodeRabbit comments addressed in commit 3831b2b: it.ts Italian labels corrected (Spazio dei nomi, Tutti gli spazi dei nomi, Collegamenti), ru.ts Russian grammar fixed (Средняя кластеризация), graphCohesion.test.ts precision updated to toBe(0.833333). Merge conflicts resolved; frontend quality and Playwright gate should now pass.

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

app/src/lib/i18n/en.ts (1)

466-514: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Remove the duplicated graphCohesion.* block in en.ts
app/src/lib/i18n/en.ts defines graphCohesion.* twice (two consecutive identical blocks). In the object literal, the second block overwrites the first—keep only one graphCohesion block.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/lib/i18n/en.ts` around lines 466 - 514, The file contains a
duplicated graphCohesion key block (multiple 'graphCohesion.*' entries
repeated); remove the redundant duplicate so each 'graphCohesion.*' key appears
only once in the exported object (locate the repeated 'graphCohesion.title',
'graphCohesion.intro', etc. entries in en.ts and delete the second block or
merge them if any differences exist), ensuring the remaining block preserves the
original strings.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/src/lib/memory/graphCohesion.ts`:
- Around line 174-178: The file contains leftover Git conflict markers around
the function signature for findBrokers; remove the conflict markers (<<<<<<<
HEAD and >>>>>>> upstream/main) and keep a single valid export function
signature with a single default for the limit parameter (use limit = 25 to match
the UI's MAX_ROWS) so the file parses and tests/other callers get the expected
default.

In `@app/src/pages/Intelligence.tsx`:
- Around line 222-236: Remove the leftover git conflict markers (<<<<<<< HEAD,
=======, >>>>>>> upstream/main) that are present around the tab JSX so the file
parses; keep the intended conditional renders such as {activeTab ===
'associations' && <EntityAssociationsTab />}, {activeTab === 'freshness' &&
<MemoryFreshnessTab />}, {activeTab === 'timeline' && <MemoryTimelineTab />},
{activeTab === 'path' && <ConnectionPathTab />}, {activeTab === 'namespaces' &&
<NamespaceOverviewTab />}, and {activeTab === 'council' && <ModelCouncilTab />}
and remove only the conflict marker lines so the JSX compiles and typechecks.

---

Outside diff comments:
In `@app/src/lib/i18n/en.ts`:
- Around line 466-514: The file contains a duplicated graphCohesion key block
(multiple 'graphCohesion.*' entries repeated); remove the redundant duplicate so
each 'graphCohesion.*' key appears only once in the exported object (locate the
repeated 'graphCohesion.title', 'graphCohesion.intro', etc. entries in en.ts and
delete the second block or merge them if any differences exist), ensuring the
remaining block preserves the original strings.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0118b99e-d79b-47f1-b21f-63d9361ed5c8

📥 Commits

Reviewing files that changed from the base of the PR and between f9175e0 and 3831b2b.

📒 Files selected for processing (4)

• app/src/lib/i18n/en.ts
• app/src/lib/memory/graphCohesion.test.ts
• app/src/lib/memory/graphCohesion.ts
• app/src/pages/Intelligence.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

• app/src/lib/memory/graphCohesion.test.ts