Conversation
…r properties while maintaining their tier (chipped, flawed, etc)
| } | ||
|
|
||
| func swapGemPropertiesFromCache(s scrambler, f *d2fs.File, origRows [][]string, destRow int, sourceRow int) { | ||
| //fmt.Printf("Swapping\n%+v\nWith\n%+v\n", f.Rows[destRow], origRows[sourceRow]) |
There was a problem hiding this comment.
Uncomment this line to easily debug this PR
|
Hi thanks for the PR, I have not had the time to review it. maybe @Deadlock39 @Wraithulek or @OldBeardedCoder could take a look? |
|
Have you looked at the new Scorer module I've been baking for the last month & a half? I believe it might make sense to generate all new properties for gems and runes instead of just swapping them. It makes sense to me to use PropScores to score the affixes in Gems.txt, then roll for properties in PropScores.txt that match the score within a certain percentage. This would allow you the possibility of getting affixes like blah% chance to cast level blah fireball. I do have a question though, does modifying Gems.txt affect already socketed items? |
3 participants
Hey there, thanks for reviewing the PR
This is not intended to be accepted as-is. Please leave any feedback or improvements you see.
TODO (will update):