fix: chunked response parser and video creation source IDs#30
Open
SteveDiamond wants to merge 1 commit intotmc:mainfrom
Open
fix: chunked response parser and video creation source IDs#30SteveDiamond wants to merge 1 commit intotmc:mainfrom
SteveDiamond wants to merge 1 commit intotmc:mainfrom
Conversation
The chunked response parser was including the next chunk's size marker as data because the declared chunk size includes a trailing \n that bufio.Scanner strips. Accept chunks within 2 bytes of declared size. Video creation was using a hardcoded test source ID instead of fetching actual sources from the notebook. Now dynamically looks up sources via GetProject and uses the first source (multi-source format TBD). Also switches video status check from audio RPC (VUsiyb) to the video RPC (R7cb6c) with get mode. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\nthatbufio.Scannerstrips. Now accepts chunks within 2 bytes of declared size.d7236810-...) with dynamic lookup viaGetProject, so video creation uses actual notebook sources.tryVideoOverviewDirectRPCfrom using the audio RPC (VUsiyb) to the video RPC (R7cb6c) with get mode ([1]).Test plan
nlm add <notebook-id> <url>correctly returns the source ID (no parse error)nlm video-create <notebook-id> <instructions>uses actual notebook sourcesnlm audio-createand other commands still parse chunked responses correctly🤖 Generated with Claude Code