Skip to content

fix: pre-existing issues in server.py and common.py (raise_if_dead, has_minimum_version) #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tony wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: pre-existing issues in server.py and common.py (raise_if_dead, has_minimum_version) #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a99e55
common(fix[has_minimum_version]): cache get_version() to avoid double…
tony Mar 7, 2026
2335b2b
server(docs[raise_if_dead]): add Raises section documenting both exce…
tony Mar 8, 2026
cd81d15
server(fix[raise_if_dead]): suppress check_call stdout/stderr
tony Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/libtmux/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,11 +456,12 @@ def has_minimum_version(raises: bool = True) -> bool:
Versions will now remove trailing letters per
`Issue 55 <https://github.com/tmux-python/tmuxp/issues/55>`_.
"""
if get_version() < LooseVersion(TMUX_MIN_VERSION):
current_version = get_version()
if current_version < LooseVersion(TMUX_MIN_VERSION):
if raises:
msg = (
f"libtmux only supports tmux {TMUX_MIN_VERSION} and greater. This "
f"system has {get_version()} installed. Upgrade your tmux to use "
f"system has {current_version} installed. Upgrade your tmux to use "
"libtmux, or use libtmux v0.48.x for older tmux versions."
)
raise exc.VersionTooLow(msg)
Expand Down
14 changes: 13 additions & 1 deletion src/libtmux/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,14 @@ def is_alive(self) -> bool:
def raise_if_dead(self) -> None:
"""Raise if server not connected.

Raises
------
:exc:`exc.TmuxCommandNotFound`
When the tmux binary cannot be found or executed.
:class:`subprocess.CalledProcessError`
When the tmux server is not running (non-zero exit from
``list-sessions``).

>>> tmux = Server(socket_name="no_exist")
>>> try:
... tmux.raise_if_dead()
Expand All @@ -232,7 +240,11 @@ def raise_if_dead(self) -> None:
if self.config_file:
cmd_args.insert(0, f"-f{self.config_file}")

subprocess.check_call([tmux_bin, *cmd_args])
subprocess.check_call(
[tmux_bin, *cmd_args],
stdout=subprocess.DEVNULL,
stderr=subprocess.DEVNULL,
)

#
# Command
Expand Down