Give "all that" even with multiple calcs#320
Open
Aras14HD wants to merge 2 commits intotolik518:masterfrom
Open
Give "all that" even with multiple calcs#320Aras14HD wants to merge 2 commits intotolik518:masterfrom
Aras14HD wants to merge 2 commits intotolik518:masterfrom
Conversation
Owner
|
Could you please add a (integration) test with the comment from the issue? #311 |
Collaborator
Author
|
Problem is, that test case doesn't break like that, it gives the expected (but maybe not wanted) Now the question is, do we want to change the order and first try to reply with "all that" before removing calculations? I think that way makes more sense. |
bf8569c to
3475d74
Compare
Collaborator
Author
|
I have in the last commit done that. And added an exception for steps (seemed unreadable to me) and made it so, that, when ops are not nested, "All that of" is not used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just removes the check before aggressive shortening whether it is only one calc.
Resolves #311