Skip to content

Give "all that" even with multiple calcs#320

Open
Aras14HD wants to merge 2 commits intotolik518:masterfrom
Aras14HD:always-post
Open

Give "all that" even with multiple calcs#320
Aras14HD wants to merge 2 commits intotolik518:masterfrom
Aras14HD:always-post

Conversation

@Aras14HD
Copy link
Collaborator

Just removes the check before aggressive shortening whether it is only one calc.

Resolves #311

@tolik518
Copy link
Owner

Could you please add a (integration) test with the comment from the issue? #311

@Aras14HD
Copy link
Collaborator Author

Problem is, that test case doesn't break like that, it gives the expected (but maybe not wanted) If I posted all numbers, the comment would get too long. So I had to remove some of them.\n\nFactorial of 99 is roughly 9.332621544394415268169923885627 × 10^155 \n\n\n*^(This action was performed by a bot | [Source code](http://f.r0.fyi))*.

Now the question is, do we want to change the order and first try to reply with "all that" before removing calculations? I think that way makes more sense.

@Aras14HD
Copy link
Collaborator Author

I have in the last commit done that. And added an exception for steps (seemed unreadable to me) and made it so, that, when ops are not nested, "All that of" is not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Factorion uses fallback message on multiple very long factorials

2 participants