(partially) revert monitoring for impossible disconnect#325
Merged
tolik518 merged 2 commits intotolik518:masterfrom Feb 26, 2026
Merged
(partially) revert monitoring for impossible disconnect#325tolik518 merged 2 commits intotolik518:masterfrom
tolik518 merged 2 commits intotolik518:masterfrom
Conversation
Collaborator
Author
|
I also would want to make the polling for comments message debug, as it is way too common (so much so that we filter it out and ignore it) |
Owner
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #318 I added monitoring on the suspicion, that we were missing some comments. This was not sensible, everything it has caught are false positives, where the "canary" comment was deleted and one new comment was posted.
I now checked and confirmed, that the query "before", that we use is immediate (always gets the next comment, no matter how many comments there are), so no comments can be missed by us.
I kept in the log for losing that connection, but as info, because it is an external thing, when people delete comments.
For the same reason, I made thread id densification failure only info when the thread id is just an empty string, and made the likely harmless "Missing ratelimit" info as well.
Also added a warn for when we actually reach capacity, indicated by getting COMMENT_COUNT responses. And took the opportunity to add exeptions like for status 500 for further server errors.
So mostly making the log cleaner/less cluttered.