Skip to content

(partially) revert monitoring for impossible disconnect#325

Merged
tolik518 merged 2 commits intotolik518:masterfrom
Aras14HD:revert-monitor-disconnect
Feb 26, 2026
Merged

(partially) revert monitoring for impossible disconnect#325
tolik518 merged 2 commits intotolik518:masterfrom
Aras14HD:revert-monitor-disconnect

Conversation

@Aras14HD
Copy link
Collaborator

In #318 I added monitoring on the suspicion, that we were missing some comments. This was not sensible, everything it has caught are false positives, where the "canary" comment was deleted and one new comment was posted.

I now checked and confirmed, that the query "before", that we use is immediate (always gets the next comment, no matter how many comments there are), so no comments can be missed by us.

I kept in the log for losing that connection, but as info, because it is an external thing, when people delete comments.
For the same reason, I made thread id densification failure only info when the thread id is just an empty string, and made the likely harmless "Missing ratelimit" info as well.

Also added a warn for when we actually reach capacity, indicated by getting COMMENT_COUNT responses. And took the opportunity to add exeptions like for status 500 for further server errors.

So mostly making the log cleaner/less cluttered.

@Aras14HD
Copy link
Collaborator Author

I also would want to make the polling for comments message debug, as it is way too common (so much so that we filter it out and ignore it)

@tolik518
Copy link
Owner

debug makes sense to me, as you have mentioned, it's something we don't usually want to see, but sometimes I still find it helpful to see a heartbeat

@tolik518 tolik518 merged commit caf2c5b into tolik518:master Feb 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants