-
Notifications
You must be signed in to change notification settings - Fork 0
fix(governance): deutsches pr-regelwerk und merge-gate fuer code-scanning-0 #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bf96d31
fix(governance): deutsches pr-regelwerk und fail-closed code-scanning…
github-actions[bot] 0ccdb97
fix(ci): erlaubtes legacy-branchformat fuer governance-check
github-actions[bot] 697eb99
fix(preflight): map neue naming-policy auf bestehende rule-datei
github-actions[bot] b8fa4dc
fix(test): behebe qodana high findings im fuzzing-smoke-test
github-actions[bot] 4e4803e
fix(review): address copilot comments for shell-headers and changelog
github-actions[bot] 96edc26
fix(ci): align preflight evidence paths and tighten governance gate
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| ## Ziel & Scope | ||
| - Ziel: | ||
| - Scope (in): | ||
| - Non-Goals (out): | ||
|
|
||
| ## Umgesetzte Aufgaben (abhaken) | ||
| - [ ] Aufgabe 1 umgesetzt | ||
| - [ ] Aufgabe 2 umgesetzt | ||
| - [ ] Aufgabe 3 umgesetzt | ||
|
|
||
| ## Nachbesserungen aus Review (iterativ) | ||
| - [ ] Alle Copilot-/Reviewer-Kommentare geprueft | ||
| - [ ] Alle notwendigen Code-Nachbesserungen umgesetzt | ||
| - [ ] PR-Beschreibung nach Nachbesserung aktualisiert | ||
| - [ ] Alle Threads `resolved` (inkl. outdated) | ||
|
|
||
| ## Security- und Merge-Gates | ||
| - [ ] Required Checks sind gruen | ||
| - [ ] `security/code-scanning/tools`: 0 offene Alerts | ||
| - [ ] Keine offenen blocker findings | ||
|
|
||
| ## Evidence (auditierbar) | ||
| - [ ] Build/Test/Checks mit Artefakten vorhanden | ||
| - [ ] Relevante Befehle im PR-Text dokumentiert | ||
| - [ ] Risiken/Assumptions explizit benannt | ||
|
|
||
| ## DoD (mindestens 2 pro Punkt) | ||
| | Punkt | DoD A | DoD B | Status | | ||
| | --- | --- | --- | --- | | ||
| | Aufgabe 1 | | | [ ] | | ||
| | Aufgabe 2 | | | [ ] | | ||
| | Aufgabe 3 | | | [ ] | | ||
|
|
||
| ## Risiken / Open Items | ||
| - [ ] keine | ||
| - [ ] vorhanden (unten auflisten) | ||
|
|
||
| ### Details (nur falls vorhanden) | ||
| - Risiko 1: | ||
| - Risiko 2: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| # Policy Branch/PR Naming (DE) | ||
|
|
||
| ## 1. Zweck | ||
| Diese Policy definiert ein einheitliches, professionelles und maschinenpruefbares Naming fuer Branches und Pull Requests. | ||
|
|
||
| ## 2. Verbindliche Konventionen | ||
|
|
||
| ### 2.1 Branches | ||
| - Muss-Format: `codex/<tag>/<kurztext-kebab>` | ||
| - Uebergang (legacy, befristet): `codex/<tag>-<kurztext-kebab>` wird fuer bestehende Branches akzeptiert. | ||
| - Erlaubte `<tag>`: | ||
| - `fix` | ||
| - `release` | ||
| - `feat` | ||
| - `refactor` | ||
| - `docs` | ||
| - `test` | ||
| - `ci` | ||
| - `chore` | ||
| - `security` | ||
| - `<kurztext-kebab>`: | ||
| - nur `a-z`, `0-9`, `-` | ||
| - keine Leerzeichen, keine Sonderzeichen | ||
| - mindestens 3 Zeichen | ||
|
|
||
| ### 2.2 PR-Titel | ||
| - Muss-Format: `<tag>(<scope>): <deutsche kurzbeschreibung>` | ||
| - `tag` wie oben. | ||
| - `scope`: | ||
| - nur `a-z0-9-` | ||
| - optional, aber empfohlen. | ||
| - Kurzbeschreibung: | ||
| - Deutsch, | ||
| - praezise, kein Platzhaltertext, | ||
| - Ergebnis-/Aenderungsbezug. | ||
|
|
||
| ### 2.3 PR-Beschreibung | ||
| - Muss auf Deutsch sein. | ||
| - Muss die Repository-PR-Template-Struktur einhalten. | ||
| - Muss Checklisten und DoD-Matrix enthalten. | ||
|
|
||
| ## 3. Verbotene Muster | ||
| - Unpraezise Titel wie `update`, `changes`, `misc`. | ||
| - Branches ohne Tag-Segment. | ||
| - PRs ohne Checklistenpflege nach Nachbesserungen. | ||
|
|
||
| ## 4. Durchsetzung | ||
| - CI-Check `pr-governance` validiert: | ||
| - Branch-Format, | ||
| - PR-Titel-Format, | ||
| - Pflichtsektionen und Checklisten in der PR-Beschreibung. | ||
| - Fail-closed: Verstoss blockiert Merge. | ||
|
|
||
| ## 5. DoD | ||
| - DoD A: `pr-governance` laeuft erfolgreich fuer die PR. | ||
| - DoD B: Branch- und PR-Name entsprechen exakt der Konvention. | ||
|
|
||
| ## 6. Rule Mapping | ||
| - Normative Rule-Datei: `tools/ci/policies/rules/naming_snt.yaml` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
tests/FileTypeDetectionLib.Tests/Unit/Fuzzing/FsCheckSmokeTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| namespace FileTypeDetectionLib.Tests.Unit.Fuzzing; | ||
|
|
||
| public sealed class FsCheckSmokeTests | ||
| { | ||
| [Fact] | ||
| public void FuzzingSmoke_GeneratorProducesSamples() | ||
| { | ||
| // FsCheck-based fuzzing signal: randomized sample generation. | ||
| var samples = FsCheck.FSharp.Gen.Sample(20, FsCheck.FSharp.Gen.Choose(0, 100)); | ||
| Assert.Equal(20, samples.Count()); | ||
| Assert.All(samples, value => Assert.InRange(value, 0, 100)); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.