Conversation
What was broken QA still saw a Prisma unique-conflict error when reassigning the same member to a private engagement after the earlier assignment was completed. The prior service planner fix was correct for terminal assignments, but a QA branch or environment can still retain the old broad engagement/member unique index and reject the new history row. Root cause The database uniqueness shape must allow multiple historical rows for the same engagement and member while still enforcing one active assignment. When the stale broad unique index remains, creating the new selected assignment after a completed or terminated assignment fails before the service can return the expected updated engagement. What was changed Added a follow-up migration that defensively drops the old broad EngagementAssignment engagementId/memberId unique index. The migration also re-creates the non-unique lookup index and the active-only unique index for SELECTED and ASSIGNED assignments. Any added/updated tests No new tests were added because the existing engagement service coverage already exercises same-member reassignment after COMPLETED and TERMINATED assignments. Validation was run with lint, build, and the full Jest suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
QA still saw a Prisma unique-conflict error when reassigning the same member to a private engagement after the earlier assignment was completed.
The prior service planner fix was correct for terminal assignments, but a QA branch or environment can still retain the old broad engagement/member unique index and reject the new history row.
Root cause
The database uniqueness shape must allow multiple historical rows for the same engagement and member while still enforcing one active assignment.
When the stale broad unique index remains, creating the new selected assignment after a completed or terminated assignment fails before the service can return the expected updated engagement.
What was changed
Added a follow-up migration that defensively drops the old broad EngagementAssignment engagementId/memberId unique index.
The migration also re-creates the non-unique lookup index and the active-only unique index for SELECTED and ASSIGNED assignments.
Any added/updated tests
No new tests were added because the existing engagement service coverage already exercises same-member reassignment after COMPLETED and TERMINATED assignments.
Validation was run with lint, build, and the full Jest suite.
Validation
source ~/.nvm/nvm.sh && nvm use && pnpm lintsource ~/.nvm/nvm.sh && nvm use && pnpm buildsource ~/.nvm/nvm.sh && nvm use && pnpm test