Allow users to set their own holidays #1399
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| </div> | ||
| ))} | ||
| && displayedUsers.map((user, userIndex) => { | ||
| const isHolidayStatus = user.status === LeaveStatus.WIPRO_HOLIDAY |
There was a problem hiding this comment.
[maintainability]
Consider extracting the logic for determining isHolidayStatus into a separate function for better readability and maintainability. This will make the code easier to test and understand.
| await updateLeaveDates(Array.from(selectedDates), LeaveStatus.HOLIDAY) | ||
| setSelectedDates(new Set()) | ||
| await loadCurrentMonth() | ||
| } catch { |
There was a problem hiding this comment.
[maintainability]
Consider adding specific error handling for different types of errors that might occur during updateLeaveDates or loadCurrentMonth. This will provide more informative feedback to the user and help with debugging.
| secondary | ||
| variant='warning' | ||
| onClick={handleSetAsHoliday} | ||
| disabled={!selectedDates.size || isUpdating} |
There was a problem hiding this comment.
[💡 design]
Ensure that the variant='warning' for the 'Set as Personal Holiday' button aligns with the design guidelines and user expectations. This variant might imply a cautionary action, which may not be the intended user experience.
Requested functionality