Renaming view to trailing and leading and adding rtl support.#8
Open
aloisdeniel wants to merge 1 commit intotoshiaki-h:masterfrom
Open
Renaming view to trailing and leading and adding rtl support.#8aloisdeniel wants to merge 1 commit intotoshiaki-h:masterfrom
trailing and leading and adding rtl support.#8aloisdeniel wants to merge 1 commit intotoshiaki-h:masterfrom
Conversation
Renaming view to `trailing` and `leading`. Adding `rtl` support.
Owner
|
Thank you for your PR. But I'm not going to accept this PR. |
Author
|
Oh yes, a And |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I renamed
view1andview2totrailingandleading, which I find more clear (we already have those terms in AppBar, GridTileBar, ListTile for example).This PR also adds
rtlsupport which means that leading and trailing views are inverted when the text direction of the application isrtland the mode is horizontal.