Follow logs in tower cloud by bradhe · Pull Request #73 · tower/tower-cli

bradhe · 2025-07-27T12:39:28Z

This PR introduces the ability to follow Tower runs in the Tower cloud when you invoke them locally. The behavior by default is such that when you to a tower run the CLI will follow the logs. You can run tower run --detach to have it run locally, and you'll get a link to the Tower UI back.

You can see a demo here: https://asciinema.org/a/PWMkIRy6Igl3FeY3hzygGQg55

Note: I also relaxed the constraints of the CLI a little bit such that it can handle enums that don't match spec.

- Remove boxed models, since that's more what we expect. - For detached runs, make sure all that works. - For attached runs, print messages that are useful at the end.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

socksy · 2025-07-28T10:34:02Z

crates/tower-cmd/src/api.rs

+    while let Some(event) = source.next().await {
+        match event {
+            Ok(reqwest_eventsource::Event::Open) => {
+                // TODO: This shouldn't happen.


these sorts of comments just tempt fate

correct--good point :) I added a panic.

socksy · 2025-07-28T10:38:13Z

crates/tower-cmd/src/api.rs

+    let api_config: configuration::Configuration = config.into();
+
+    // These represent the messages that we'll stream to the client.
+    let (tx, rx) = mpsc::channel(1);


tx = transmit?

Yep, tx = transmit, rx = receive. Convention from the Tokio docs.

Ha! I commented the same. Very weird naming

socksy · 2025-07-28T10:44:36Z

crates/tower-cmd/src/apps.rs

+            let dt: DateTime<Utc> = DateTime::parse_from_rfc3339(&line.timestamp)
+                .unwrap()
+                .with_timezone(&Utc);
+            let ts = dt.format("%Y-%m-%d %H:%M:%S").to_string();


same as "%F %T" btw

Ah nice. I'll update this. Actually, I'll refactor it out, too, to make it consistent.

socksy · 2025-07-28T10:49:52Z

scripts/rust-client-templates/model.mustache

    }
 }

+impl<'de> Deserialize<'de> for {{{classname}}} {


What's going on here? How come all the auto generated code now derives Deserializer as well as Deserialize?

It's a bit hard to follow since it's in this (very hairy) mustache template. For enum types (with name {{{classname}}}), we implement the Deserialize trait. It takes an argument D which implements the Deserializer trait.

All of this is meant to allow us to deserialize enum types in a case-insensitive way! So both "PROGRAM" and "program" can deserialize to Channel::Program. It's otherwise very strict and often breaks out API when we don't conform to the spec--which, actually, was exactly what was happening for log lines and was blocking work on this PR!

konstantinoscs · 2025-07-28T14:39:48Z

crates/tower-cmd/src/api.rs

+    let api_config: configuration::Configuration = config.into();
+
+    // These represent the messages that we'll stream to the client.
+    let (tx, rx) = mpsc::channel(1);


Ha! I commented the same. Very weird naming

crates/tower-cmd/src/error.rs

crates/tower-cmd/src/run.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull Request Overview

This PR introduces the ability to follow Tower runs in real-time from the CLI and includes generated API model updates. The default behavior now follows run logs when executing tower run, with an optional --detach flag to run without following. Additionally, the Rust client generator configuration has been updated to handle enum deserialization more flexibly.

Key changes include:

Added real-time run following functionality with log streaming and completion monitoring
Added --detach flag to disable log following behavior
Updated generated API models to handle case-insensitive enum deserialization
Enhanced error handling and Ctrl+C interrupt support

Reviewed Changes

Copilot reviewed 172 out of 173 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`crates/tower-cmd/src/run.rs`	Main implementation of run following functionality with log streaming and completion monitoring
`crates/tower-cmd/src/api.rs`	Added event streaming support and new API endpoints for run monitoring
`crates/tower-cmd/src/util/dates.rs`	New utility module for consistent timestamp formatting
`scripts/rust-client-templates/model.mustache`	Updated enum deserialization to be case-insensitive and more flexible
`crates/tower-api/src/models/*.rs`	Generated API model updates with improved enum handling and removed boxed types

Comments suppressed due to low confidence (1)

crates/tower-cmd/src/run.rs:77

The match pattern uses Ok(Self::{{{name}}}) in the template but here it's missing the Ok() wrapper. This should be Ok(Self::Scheduled) to maintain consistency with the deserialization pattern.

);

Copilot · 2025-07-28T16:43:08Z

crates/tower-cmd/src/api.rs

+    while let Some(event) = source.next().await {
+        match event {
+            Ok(reqwest_eventsource::Event::Open) => {
+                panic!("Received unexpected open event in log stream. This shouldn't happen.");


Using panic! in production code should be avoided. Consider returning an error instead of panicking, as this could crash the entire application unexpectedly.

Suggested change

panic!("Received unexpected open event in log stream. This shouldn't happen.");

debug!("Received unexpected open event in log stream. This shouldn't happen.");

break; // Exit the loop gracefully

Copilot · 2025-07-28T16:43:08Z

crates/tower-cmd/src/api.rs

+            },
+            Ok(Event::Message(message)) => {
+                // This is a bug in the program and should never happen.
+                panic!("Received message when expected an open event. Message: {:?}", message);


Using panic! in production code should be avoided. Consider returning an error instead of panicking to maintain application stability.

Copilot · 2025-07-28T16:43:08Z

crates/tower-cmd/src/run.rs

+       let run = wait_for_run_completion(&config_clone, &run_clone).
+           await.
+           unwrap();
+


Using unwrap() in async code can cause panics. Consider proper error handling and propagating the error to the caller instead of unwrapping.

Suggested change

let run = wait_for_run_completion(&config_clone, &run_clone).

await.

unwrap();

match wait_for_run_completion(&config_clone, &run_clone).await {

Ok(run) => {

let _ = tx.send(run);

}

Err(e) => {

eprintln!("Error waiting for run completion: {:?}", e);

}

}

Is this relevant?
Edit: I mean the copilot comment at the same line

I think we want it to panic in this case. The CLI will just die.

crates/tower-cmd/src/run.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

konstantinoscs

Ok with me but I would prefer it if @socksy was also satisfied before we merge this

konstantinoscs · 2025-07-28T16:58:55Z

crates/tower-cmd/src/run.rs

+       let run = wait_for_run_completion(&config_clone, &run_clone).
+           await.
+           unwrap();
+


Is this relevant?
Edit: I mean the copilot comment at the same line

bradhe added 5 commits July 25, 2025 16:19

chore: Checkpoint

2dbe91c

chore: Another checkpoint

5a5ad60

chore: Upgrade tower-api to the latest

d9d6c97

chore: Progress on getting eventsources there

0cb78c6

chore: Upgrade the Tower API client and add a log stream client

acaba9e

bradhe requested review from Copilot, konstantinoscs and socksy July 27, 2025 12:39

This comment was marked as outdated.

Sign in to view

bradhe and others added 6 commits July 28, 2025 11:01

chore: Make enum deserialization case insensitive

26d0116

chore: When a run completes, we should stop following it.

49af4dd

chore: Format dates a little nicer.

3eaa5dc

chore: A few updates.

6783e23

- Remove boxed models, since that's more what we expect. - For detached runs, make sure all that works. - For attached runs, print messages that are useful at the end.

Update crates/tower-cmd/src/run.rs

9616bc5

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update crates/tower-cmd/src/api.rs

d6f8347

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

socksy reviewed Jul 28, 2025

View reviewed changes

bradhe added 2 commits July 28, 2025 13:38

chore: Centralize date formatting

fc73e8f

chore: Add Ctrl+C detection

ea063fc

konstantinoscs reviewed Jul 28, 2025

View reviewed changes

bradhe and others added 4 commits July 28, 2025 17:13

Update crates/tower-cmd/src/run.rs

dec0ba1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

chore: Remove legacy comment

232d36e

chore: Remove short form of --dir and move it to --detached

2c7f204

chore: Improved naming

1955173

bradhe requested a review from Copilot July 28, 2025 16:42

Copilot AI reviewed Jul 28, 2025

View reviewed changes

Update crates/tower-cmd/src/run.rs

380f76d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

konstantinoscs approved these changes Jul 28, 2025

View reviewed changes

bradhe merged commit 345846b into develop Jul 28, 2025
4 checks passed

bradhe deleted the feature/follow-logs-in-tower-cloud branch July 28, 2025 17:09

	panic!("Received unexpected open event in log stream. This shouldn't happen.");
	debug!("Received unexpected open event in log stream. This shouldn't happen.");
	break; // Exit the loop gracefully

-       let run = wait_for_run_completion(&config_clone, &run_clone).
-           await.
-           unwrap();
+       match wait_for_run_completion(&config_clone, &run_clone).await {
+           Ok(run) => {
+               let _ = tx.send(run);
+           }
+           Err(e) => {
+               eprintln!("Error waiting for run completion: {:?}", e);
+           }
+       }

Conversation

bradhe commented Jul 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 28, 2025

Choose a reason for hiding this comment

Uh oh!

konstantinoscs Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

konstantinoscs left a comment

Choose a reason for hiding this comment

Uh oh!

konstantinoscs Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bradhe commented Jul 27, 2025 •

edited

Loading

konstantinoscs Jul 28, 2025 •

edited

Loading

konstantinoscs Jul 28, 2025 •

edited

Loading