Skip to content

fix: don't assume 422 are validation errors #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
konstantinoscs merged 2 commits into from
Aug 22, 2025
Merged

fix: don't assume 422 are validation errors #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efebdae
fix: don't assume 422 are validation errors
konstantinoscs Aug 19, 2025
c277051
fix: improve error message displaying
konstantinoscs Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 35 additions & 37 deletions crates/tower-cmd/src/output.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,57 +116,55 @@ pub fn runtime_error(err: tower_runtime::errors::Error) {
io::stdout().write_all(line.as_bytes()).unwrap();
}

// Outputs both the model.detail and the model.errors fields in a human readable format.
pub fn output_full_error_details(model: &ErrorModel) {
// Show the main detail message if available
if let Some(detail) = &model.detail {
writeln!(io::stdout(), "\n{}", "Error details:".yellow()).unwrap();
writeln!(io::stdout(), "{}", detail.red()).unwrap();
}

// Show any additional error details from the errors field
if let Some(errors) = &model.errors {
if !errors.is_empty() {
if model.detail.is_none() {
writeln!(io::stdout(), "\n{}", "Error details:".yellow()).unwrap();
}
for error in errors {
let msg = format!(
" • {}",
error.message.as_deref().unwrap_or("Unknown error")
);
writeln!(io::stdout(), "{}", msg.red()).unwrap();
}
}
}
}

fn output_response_content_error<T>(err: ResponseContent<T>) {
// Attempt to deserialize the error content into an ErrorModel.
let error_model: ErrorModel = match serde_json::from_str(&err.content) {
Ok(model) => model,
let error_model = match serde_json::from_str::<ErrorModel>(&err.content) {
Ok(model) => {
debug!("Error model (status: {}): {:?}", err.status, model);
model
},
Err(e) => {
debug!("Failed to parse error content as JSON: {}", e);
debug!("Raw error content: {}", err.content);
error("An unexpected error occurred while processing the response.");
// Show the raw error content if JSON parsing fails
writeln!(io::stdout(), "\n{}", "API Error:".yellow()).unwrap();
writeln!(io::stdout(), "{}", err.content.red()).unwrap();
return;
}
};
debug!("Error model (status: {}): {:?}", err.status, error_model);

match err.status {
StatusCode::CONFLICT => {
// Show the main error message from the detail field
error("There was a conflict while trying to do that!");

// Show any additional error details from the errors field
if let Some(errors) = &error_model.errors {
if !errors.is_empty() {
writeln!(io::stdout(), "\n{}", "Error details:".yellow()).unwrap();
for error in errors {
let msg = format!(
" • {}",
error.message.as_deref().unwrap_or("Unknown error")
);
writeln!(io::stdout(), "{}", msg.red()).unwrap();
}
}
}

output_full_error_details(&error_model);
},
StatusCode::UNPROCESSABLE_ENTITY => {
// Show the main error message from the detail field
let line = format!("{} {}\n", "Validation error:".red(), "You need to fix one or more validation errors");
io::stdout().write_all(line.as_bytes()).unwrap();

// Show any additional error details from the errors field
if let Some(errors) = &error_model.errors {
if !errors.is_empty() {
writeln!(io::stdout(), "\n{}", "Error details:".yellow()).unwrap();
for error in errors {
let msg = format!(
" • {}",
error.message.as_deref().unwrap_or("Unknown error")
);
writeln!(io::stdout(), "{}", msg.red()).unwrap();
}
}
}
output_full_error_details(&error_model);
},
StatusCode::INTERNAL_SERVER_ERROR => {
error("The Tower API encountered an internal error. Maybe try again later on.");
Expand Down
5 changes: 4 additions & 1 deletion crates/tower-cmd/src/util/apps.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,10 @@ pub async fn ensure_app_exists(
tower_api::apis::Error::ResponseError(resp) => resp.status,
_ => StatusCode::INTERNAL_SERVER_ERROR,
},
content: create_err.to_string(),
content: match &create_err {
tower_api::apis::Error::ResponseError(resp) => resp.content.clone(),
_ => create_err.to_string(),
},
entity: None,
},
))
Expand Down
Loading