chore: make armv7-unknown-linux-musleabihf optional#85
Merged
Conversation
armv7-unknown-linux-musleabihf is a [Tier 2 without Host Tools](https://doc.rust-lang.org/beta/rustc/platform-support.html#tier-2-without-host-tools) target. That means that we should expect it to not always build, as they do not provide any guarantees that it will. Since there's already a arm-unknown-linux-gnueabihf target, I don't think it should be the end of the world if the LLVM version doesn't build - at least there's still a binary for that platform. So in order to deal with the intermittent builds, I'm making this job not block
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes the armv7-unknown-linux-musleabihf target optional in the CI build process to prevent intermittent build failures from blocking the entire CI pipeline. Since this is a Tier 2 without Host Tools target that doesn't guarantee successful builds, and there's already an alternative arm-unknown-linux-gnueabihf target available, allowing this specific target to fail gracefully improves CI reliability.
Key changes:
- Added conditional
continue-on-errorflag for the armv7-unknown-linux-musleabihf target in the musllinux-cross job
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
Of course when I make a PR specifically for this, the job passes 🙄 |
konstantinoscs
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
armv7-unknown-linux-musleabihf is a Tier 2 without Host Tools target. That means that we should expect it to not always build, as they do not provide any guarantees that it will.
Since there's already a arm-unknown-linux-gnueabihf target, I don't think it should be the end of the world if the LLVM version doesn't build - at least there's still a binary for that platform. So in order to deal with the intermittent builds, I'm making this job not block the CI.