Skip to content

Conversation

@tommyjcarpenter
Copy link

making pippable. using logger instead of print statements. getting rid of implict/relative imports.

@tommyjcarpenter
Copy link
Author

In general it is a bad idea to have the module folder name be the same name as a module inside of that folder, because then imports become complicated. I defined logger inside of your init, but when I said from gps import logger it could not resolve this, and that is because there was another module called gps.

So, I have renamed your module folder in my branch for this reason. I've also removed all relative imports and I removed your import *s in the init because surely that is a bad way to do things, but I may have broken something we need to fix by doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant