Open
Conversation
In a windows terminal, the character set is typically *not* UTF-8. This
means that Windows users will most likely read and/or write wrong data
when using vim-dadbod, if they use characters outside ASCII.
This patch does two things to fix this problem:
1. Prepend `chcp 65001` before the command of any database tool used
by dadbod, but only when running on Windows. Code page 65001 is
Microsofts name for UTF-8. (This fixes reading from most database
tools)
2. Add command-line arguments to sqlcmd (used to communicate with SQL
Server) to use utf-8. (This was necessary to write data correctly
to sqlserver. It might not be needed on other platforms than
windows, but certainly does not hurt. Other tools might need
similar fixes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a windows terminal, the character set is typically not UTF-8. This means that Windows users will most likely read and/or write wrong data when using vim-dadbod, if they use characters outside ASCII.
This patch does two things to fix this problem:
chcp 65001before the command of any database tool used by dadbod, but only when running on Windows. Code page 65001 is Microsofts name for UTF-8. (This fixes reading from most database tools)See also #193