[pull] master from golang:master#37
Merged
Merged
Conversation
- use CMPW rather than CMP + Zext for <=32 bits shift counts - deduplicate rules by first rewriting 32x... 16x... and 8x... to 64x... I also had to add ANDconst → zext and REV16 + zext → into REV16W due to latent rule ordering bug. Change-Id: I394006fe09aae332a1636da7722ee5fddecec304 Reviewed-on: https://go-review.googlesource.com/c/go/+/760660 Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com>
Firstly; As far as I know we do not ever have a value inside a timespec that does not fit into a timespec32, we only ever use it for time durations which will continue to fit in timespec32 after Y2038 since it is relative. In the case that assumption is wrong I would like to be told about it. Secondly; Assuming this is false and we are storing datetimes in theses timespecs, I do not know what to do if we are trying to convert it to a 32bits timespec. Since the correct thing we are doing is to always use the 64bits codepath when it is available, thus if we try to convert such too big timespec to 32bits means the host Linux doesn't support the 64bits codepaths. Then I think it's a there is no good solution situation, and I think crashing is better than continuing with a corrupted (due to truncation) timespec32. Change-Id: I4456ff9d96d85eb3da38a938d699a6e5e99f3844 Reviewed-on: https://go-review.googlesource.com/c/go/+/751342 Auto-Submit: Jorropo <jorropo.pgm@gmail.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Document that Debug, Info, Warn, Error (both Logger methods and package-level functions) use context.Background internally, and point users to their *Context variants. Updates #44143 Change-Id: I1bfb7bc1b0d050dfa6a665233f3df9ee70510153 Reviewed-on: https://go-review.googlesource.com/c/go/+/752620 Reviewed-by: Jonathan Amsterdam <jba@google.com> Reviewed-by: Sean Liao <sean@liao.dev> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Sean Liao <sean@liao.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )