Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d604c696b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| handler.close = async () => { | ||
| const closePromises = [...transports.values()].map((t) => t.close()) | ||
| await Promise.all(closePromises) | ||
| transports.clear() | ||
| return Promise.resolve() | ||
| } |
There was a problem hiding this comment.
handler.close() was changed to a no-op, so the HTTP handler no longer has any way to terminate in-flight stateless transports/servers during shutdown. This regresses graceful stop behavior because packages/mcp-server/src/cli.ts:161-163 calls await handler.close() before server.close(), and long-lived SSE/slow requests can keep sockets open indefinitely when no transport is explicitly closed. Please keep a registry of active per-request transports (and servers) and close them in handler.close() so shutdown can reliably drain.
Useful? React with 👍 / 👎.
1 participant
Summary
Session not foundfailure modeValidation