Refactor signer name consistency enforcement in AppendOptions validation#958
Merged
Conversation
Collaborator
|
Could you add a description which explains why this change is necessary/better? |
Contributor
Author
Sure, I've just updated the pull request description. |
mhutchinson
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request defers the signer validation in
WithCheckpointSignerto avoidos.Exitandcontext.Background.Problem
The WithCheckpointSigner method was performing immediate validation on the provided signers. However, this method is a configuration setter and does not take a
context.Context. Onlycontext.Background()can be used to log errors when validation failed. Furthermore, it calledos.Exit(1)directly upon failure, which is anti-idiomatic for library code as it prevents the calling application from handling the failure gracefully.Solution
This change defers the validation of additional signers to the
valid()method ofAppendOptions. If validation fails,valid()returns an error instead of crashing the process. This approach does not cause any breaking changes.Why better?
os.Exit. This allows the application using Tessera to decide how to handle invalid configurations.valid()(which is called byNewAppenderin a context-aware environment), we no longer need to usecontext.Background()for logging errors.