Prevent out-of-range slices in MigrationStorage#959
Open
roger2hk wants to merge 1 commit into
Open
Conversation
AlCutter
reviewed
May 13, 2026
| if err != nil { | ||
| return fmt.Errorf("bundleHasherFunc for bundle index %d: %v", ri.Index, err) | ||
| } | ||
| if len(bh) < int(ri.First+ri.N) { |
Collaborator
There was a problem hiding this comment.
if l := len(bh); l < ... {
return fmt.Errorf(..., ..., l, ...)
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If the bundle fetched from storage is corrupted, incomplete, or simply shorter than what
layout.Rangeexpects for that index,bhwill have fewer elements thanri.First + ri.N. This will trigger a slice bounds out-of-range panic.Solution
This pull request adds a bounds check in
fetchLeafHashesacross AWS, GCP, and POSIX backends to prevent a potential slice out-of-bounds panic when processing truncated entry bundles during log migration.