Parser changes to improve combat intervals accuracy. Updated inline parser tests to latest format.#12
Open
Rivsoft wants to merge 1 commit intotrayburn:masterfrom
Rivsoft:master
Open
Parser changes to improve combat intervals accuracy. Updated inline parser tests to latest format.#12Rivsoft wants to merge 1 commit intotrayburn:masterfrom Rivsoft:master
Rivsoft wants to merge 1 commit intotrayburn:masterfrom
Rivsoft:master
Conversation
* Added StartTime and EndTime to ICombatMetrics interface * Fixed all inline parser tests to use the latest combat log format. All * file based parser tests needs to be updated to the new format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Ray:
Ive done some changes to the parser. I updated all inline based parser tests to use the latest combat log format. I will try to update the file based ones later.
Let me know what you think. Best regards.
Changelog: