treehouses changelog compare <version> [version] upgrade (fixes #2164)

[JLKwong]

No description provided.

[rjpadilla]

So I don't know about you, but I kept getting Error: file does not exist!.

So I pretty much made a copy of the CHANGELOG.MD from /usr/lib/node_modules/@treehouses/cli/CHANGELOG.md into my repo to get it running.

---

Moving on to the comparing:
When I run changelog compare 1.25.37 1.25.36 or vice-versa I get the output

Try 'cut --help' for more information. 
ERROR: Must specify different versions for comparisons (cannot compare same version to itself)

I wouldn't know how to fix that problem...

---

So, my idea of fixing the comparing version issue was using a test like this (but this uses ASCII, so comparing isn't guarantee):

[[ 1.25.37 > 1.25.36 ]]

or some implemetation using the sort command:

echo -e "1.25.37\n1.25.36" | sort -V

Finally you can go with the @dogi lazy option:

dpkg --compare-versions "1.0" "lt" "1.2"

[JLKwong]

So I don't know about you, but I kept getting Error: file does not exist!.

So I pretty much made a copy of the CHANGELOG.MD from /usr/lib/node_modules/@treehouses/cli/CHANGELOG.md into my repo to get it running.

Moving on to the comparing:
When I run changelog compare 1.25.37 1.25.36 or vice-versa I get the output

Try 'cut --help' for more information. 
ERROR: Must specify different versions for comparisons (cannot compare same version to itself)

I wouldn't know how to fix that problem...

So, my idea of fixing the comparing version issue was using a test like this (but this uses ASCII, so comparing isn't guarantee):

[[ 1.25.37 > 1.25.36 ]]

or some implemetation using the sort command:

echo -e "1.25.37\n1.25.36" | sort -V

Finally you can go with the @dogi lazy option:

dpkg --compare-versions "1.0" "lt" "1.2"

These bugs have been fixed. 😌✨

[rjpadilla]

The changelog compare still shows the changes between new version first and old version last. I don't know if the requirements are strict with only comparing old first and new last. But I'll probably leave out the changes and keep the "Did you mean..." line.

Anyways it looks a lot better than showing all the changes.

[rjpadilla]

I may be mistaken but I think @dogi left checking the directory for tests/changelog.bats
Also you didn't remove the CHANGELOG file....

[JLKwong]

Fixed - it now removes the duplicate CHANGELOG file.

[JLKwong]

The changelog compare still shows the changes between new version first and old version last. I don't know if the requirements are strict with only comparing old first and new last. But I'll probably leave out the changes and keep the "Did you mean..." line.

Anyways it looks a lot better than showing all the changes.

Are you saying you want an error handling message when when comparing changes with the new version first and old version last?

And you're correct, the way the code is written now, the command will 'autocorrect' by displaying the changes as if the versions were switched around, then suggest the correct way to write the command:

[JLKwong]

treehouses changelog compare will now echo the version differences regardless of whether and older or newer version is specified first or last.

[rjpadilla]

So it works...
but the CHANGELOG.md is still in the cli/ directory and you removed the CHANGELOG.md from my treehouses image.

[rjpadilla]

You can delete this. This belongs in the changelog.bats

[JLKwong]

You can delete this. This belongs in the changelog.bats

I deleted the code you mentioned.

[rjpadilla]

My changelog is gone so I can't thoroughly test. But from the previous PR, it seems it works except for the block of code that removed my changelog. Now that you removed it, I think everything is good.