Open
Conversation
Collaborator
|
What's the reason for this? |
Contributor
Author
|
Mostly to leverage the pytest ecosystem (coverage, performance etc). Pytest interact well with the major IDEs, which is a nice bonus. I dropped this pull request to show some proof of concept and if there is any interest. |
This reverts commit d87a23e.
Contributor
Author
|
@nicholasserra now the test runs an all major platform / python versions https://github.com/cav71/python-markdown2/actions/runs/1904662952 and there is a branch ready with the coverage for it https://github.com/cav71/python-markdown2/tree/coverage-support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is "preliminary" pytest port of the testlib.py code, leveraging pytest and its ecosystem.
It supports running all (unchanged) tests (tm-cases, markdowntest-cases, php-markdown-cases and php-markdown-extra-cases).
pytest itself provides extensive support for code quality (coverage, unitest xml etc.).
This change also integrates the workflow actions.