improved LSP support + type testing#10
Merged
Merged
Conversation
… of overloads on Relationship
robinvandernoord
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pycharm doesn't understand the_RelationshipAccessorlogic so this version is not usable yet!Perhaps we should simplify the Relationship stuff again, and just accept that SomeType.some_relationship is not fully typed well.That should be the biggest tradeoff in this PR.
Pycharm still doesn't understand the difference between class-level and instance-level types but at least the type-checkers do.
Todo: ensure full parity between the test_typing md files and test_mypy.py; then we may remove the pytest-mypy plugin and file.