feat(install): reject --set with multi-preset install#16
Merged
Conversation
--set / --set-env target a single preset. Bundling them with multiple confs led to confusing behavior: only one preset's prompts got filled, and the rest would block on a readline that never gets input in a non-TTY shell script. New validateInstallPolicy guard rejects the combination with a clear error before anything is written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--set/--set-envnow require installing exactly one preset. Bundling them with multiple confs let only one preset's prompts be filled and then hung on a readline for the rest in non-TTY contexts.validateInstallPolicyinsrc/cli-args.tsruns after parsing and before any write. Bin layer prints the message and exits 1.Test plan
npm test(79 pass, including 5 newvalidateInstallPolicycases)install mcp-http mcp-http-noauth --set name=x→ clean error, exit 1install --set name=x(no preset) → falls through to existing usage errorinstall mcp-http --set name=x --set url=… --set headerName=… --set headerValue=…→ still works