Skip to content

Conversation

@koszti
Copy link
Member

@koszti koszti commented Dec 15, 2025

Description

The release-and-publish github action is currently failing on the main branch when attempting to detect a version change, producing the following error:

Error: Can't find version field

To fix this, we need to update the configuration as follows:

  • Add file-name: ./precise/package.json so the action looks for package.json in the correct directory. Setting a job-level working-directory is not sufficient for this action.
  • Add diff-search: true : By default, the action only checks commit messages. If the version is bumped in package.json without explicitly mentioning it in the commit message, the release is not detected.

Additional context and related issues

These changes were tested independently in a forked repository

@cla-bot cla-bot bot added the cla-signed label Dec 15, 2025
@koszti koszti force-pushed the debug-version-push branch from 81a6c5b to 62f2132 Compare December 15, 2025 10:24
@koszti koszti force-pushed the debug-version-push branch from 6c63faa to e016c66 Compare December 15, 2025 10:27
@koszti koszti requested a review from mosabua December 15, 2025 10:34
@koszti koszti changed the title Debug version check Fix release workflow version detection Dec 15, 2025
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.. I noticed the failure too but did not get around to investigating. Thanks!

@mosabua mosabua merged commit 1ceb733 into trinodb:main Dec 15, 2025
2 checks passed
@koszti koszti deleted the debug-version-push branch December 15, 2025 18:09
@koszti
Copy link
Member Author

koszti commented Dec 15, 2025

@mosabua worfklow in main branch now looks just fine:

Searching for version update...
Searching in 1 commit...
  Package file name: "precise/package.json"
  Package file URL: undefined
  Version assumptions: undefined
No standard npm version commit found, switching to diff search (this could take more time...)
Checking the diffs of 1 commit...
  - 1ceb733: no changes to the package file
No matching commit found.
Outputs:
  changed: false

next time when we merge a version bump commit to main it should generate release notes, create release in GH and publish to npm. let’s see how it goes

@mosabua
Copy link
Member

mosabua commented Dec 15, 2025

Yeah.. if I get around to it I might cut another release tonight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants