Skip to content

fix(config): optimizes config binding for node #6755

Merged
kuny0707 merged 5 commits intotronprotocol:developfrom
317787106:hotfix/config_error
May 10, 2026
Merged

fix(config): optimizes config binding for node #6755
kuny0707 merged 5 commits intotronprotocol:developfrom
317787106:hotfix/config_error

Conversation

@317787106
Copy link
Copy Markdown
Collaborator

@317787106 317787106 commented May 9, 2026

What does this PR do?

  1. bug Fixes
  • treat "null" as unset for discovery.external.ip; bind via a flat externalIP.
  • fix the proprity of some config items, do not default allowShieldedTransactionApi in reference.conf; use it when set, else fall back to fullNodeAllowShieldedTransaction with a deprecation warning.
  1. migration
  • remove unused node bindings: node.connection.timeout, node.channel.read.timeout, node.tcpNettyWorkThreadNum, node.udpNettyWorkThreadNum

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

317787106 and others added 3 commits May 10, 2026 00:45
…parameter binding

Remove maxBlockFilterNum, maxAddressSize, and maxRequestTimeout from NodeConfig/CommonParameter
since they were superseded by the jsonRpcMaxBatchSize/jsonRpcMaxResponseSize parameters.
Consolidate the config binding path so all JSON-RPC size limits flow through a single
reference.conf entry, and clean up stale test-config fixtures.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot requested a review from halibobo1205 May 9, 2026 17:13
@317787106 317787106 changed the title fix(config): Optimizes config binding for node fix(config): optimizes config binding for node May 9, 2026
Comment thread common/src/main/java/org/tron/core/config/args/NodeConfig.java
@Sunny6889 Sunny6889 moved this to In Review in java-tron May 10, 2026
@kuny0707 kuny0707 merged commit 381d369 into tronprotocol:develop May 10, 2026
17 of 18 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in java-tron May 10, 2026
@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.8.2 milestone May 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants