Skip to content

fix(config): fix the issue where --es fails to start#6757

Merged
lvs0075 merged 7 commits intotronprotocol:release_v4.8.2from
317787106:hotfix/es_and_testcaes
May 10, 2026
Merged

fix(config): fix the issue where --es fails to start#6757
lvs0075 merged 7 commits intotronprotocol:release_v4.8.2from
317787106:hotfix/es_and_testcaes

Conversation

@317787106
Copy link
Copy Markdown
Collaborator

@317787106 317787106 commented May 10, 2026

What does this PR do?

  1. Fix the issue that node fails to start when --es and event.subscribe.enable = false exists at the same time
  2. Fix 7 falied testcase about PeerConnection

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

317787106 and others added 7 commits May 10, 2026 00:45
…parameter binding

Remove maxBlockFilterNum, maxAddressSize, and maxRequestTimeout from NodeConfig/CommonParameter
since they were superseded by the jsonRpcMaxBatchSize/jsonRpcMaxResponseSize parameters.
Consolidate the config binding path so all JSON-RPC size limits flow through a single
reference.conf entry, and clean up stale test-config fixtures.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot requested a review from halibobo1205 May 10, 2026 07:06
@halibobo1205 halibobo1205 changed the title fix(config): Fix the issue where --es fails to start fix(config): fix the issue where --es fails to start May 10, 2026
@halibobo1205 halibobo1205 added topic:event subscribe transaction trigger, block trigger, contract event, contract log topic:config labels May 10, 2026
@halibobo1205 halibobo1205 added this to the GreatVoyage-v4.8.2 milestone May 10, 2026
@lvs0075 lvs0075 merged commit 4036f03 into tronprotocol:release_v4.8.2 May 10, 2026
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic:config topic:event subscribe transaction trigger, block trigger, contract event, contract log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants