Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates CI from Travis to GitHub Actions and expands supported Python versions.
- Removes
.travis.ymland adds a new GitHub Actions workflow - Updates
pyproject.tomlclassifiers to test Python 3.8–3.13 - Cleans up minor formatting in client modules and test files
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| trustpilot/client.py | Re-formatted tuple line breaks for status code check |
| trustpilot/async_client.py | Removed extra blank lines |
| tests/test_cli.py | Removed unnecessary u prefixes from triple-quoted strings |
| pyproject.toml | Expanded Python classifiers to 3.8–3.13 |
| .travis.yml | Removed obsolete Travis CI config |
| .github/workflows/pushes.yaml | Added GitHub Actions build-and-test workflow |
| @@ -278,7 +277,6 @@ def assert_output_equal(self, output, expected_output): | |||
| @mock.patch("trustpilot.cli.client", autospec=True) | |||
| @mock.patch("trustpilot.cli.auth") | |||
| def test_no_verbosity_with_get(self, auth_mock, client_mock): | |||
There was a problem hiding this comment.
The test test_no_verbosity_with_get is defined twice in this file, which causes the first definition to be overridden. Please remove or rename the duplicate to avoid unexpected test behavior.
Suggested change
| def test_no_verbosity_with_get(self, auth_mock, client_mock): | |
| def test_no_verbosity_with_get_first(self, auth_mock, client_mock): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket 🎟
SP-148
What⁉️
Migrates from Travis to GHA and expands the number of python versions tested against