feat:Add boolean private (default false) to ModelMeta in OpenAPI#228
feat:Add boolean private (default false) to ModelMeta in OpenAPI#228
Conversation
WalkthroughAdds a new boolean field private (default: false) to the ModelMeta schema in the OpenAPI specification at src/libs/DeepInfra/openapi.yaml. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/libs/DeepInfra/openapi.yaml (1)
6859-6862: Type mismatch:ModelOut.privateis integer;ModelMeta.privateis boolean. Align to boolean.This will otherwise generate inconsistent SDK types and surprise clients.
- private: - title: Private - type: integer - default: 0 + private: + title: Private + type: boolean + default: false
🧹 Nitpick comments (2)
src/libs/DeepInfra/openapi.yaml (2)
4616-4620: Document the new field’s behavior.Add a short description clarifying visibility semantics (who can see/use a private model; listing/search effects).
private: title: Private type: boolean default: false + description: Whether the model is private (not publicly listed; visible/usable only to the owner/team).
4616-4620: Avoid dual “public” and “private” flags across schemas.
ModelInfoOutexposespublic: booleanwhileModelMeta/ModelOutexposeprivate. Prefer a single polarity everywhere (e.g.,public) or clearly mark one as deprecated and document mapping.Also applies to: 6613-6615
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
src/libs/DeepInfra/Generated/DeepInfra.Models.ModelMeta.g.csis excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/DeepInfra/openapi.yaml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test / Build, test and publish
Summary by CodeRabbit
New Features
Documentation