Skip to content

fix: apply objectLimit globally#213

Open
FJ-CX wants to merge 1 commit into
tscircuit:mainfrom
FJ-CX:fix-global-object-limit-42
Open

fix: apply objectLimit globally#213
FJ-CX wants to merge 1 commit into
tscircuit:mainfrom
FJ-CX:fix-global-object-limit-42

Conversation

@FJ-CX
Copy link
Copy Markdown

@FJ-CX FJ-CX commented May 13, 2026

Summary

  • applies objectLimit globally across all rendered object groups after layer/step/viewport filtering
  • keeps the red limit warning based on the pre-limit filtered object count
  • shows the limit warning even when the graphic has no step controls
  • adds focused regression coverage for the limiter behavior

/claim #42

Verification

  • npx biome check --write site\components\InteractiveGraphics\InteractiveGraphics.tsx site\utils\applyObjectLimit.ts tests\apply-object-limit.test.ts
  • npx tsc --noEmit
  • npm run build
  • npx --yes bun test tests/apply-object-limit.test.ts

Demo

The existing examples/interactive-object-limit-layer-and-step-filtering.fixture.tsx fixture exercises the objectLimit prop with mixed object types, layers, and steps. The implementation now caps the total rendered object count globally and displays the red limit notice using the pre-limit count.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
graphics-debug Ready Ready Preview, Comment May 13, 2026 10:48pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant